New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(updater): correct spelling of curl
flag
#11072
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omz will not auto-update on some systems using `curl`, failing at this line
ohmyzsh
bot
added
Area: core
Issue or PR related to core parts of the project
Area: updater
Update subsystem
labels
Jul 26, 2022
PennRobotics
changed the title
Fix spelling of
fix(updater): correct spelling of Jul 26, 2022
curl
flagcurl
flag
@mcornella MERGE ASAP! |
Thank you for finding this Brian, I apologize for the mistake. In order to solve this for users that have curl installed, they should manually update with |
lesterchan
added a commit
to lesterchan/oh-my-zsh
that referenced
this pull request
Jul 27, 2022
* upstream/master: fix(updater): correct spelling of `curl` flag (ohmyzsh#11072)
emcrisostomo
pushed a commit
to emcrisostomo/oh-my-zsh
that referenced
this pull request
Aug 25, 2022
tekniklr
pushed a commit
to tekniklr/oh-my-zsh
that referenced
this pull request
Sep 6, 2022
amkirby
pushed a commit
to amkirby/oh-my-zsh
that referenced
this pull request
Sep 7, 2022
Rhahkeem
pushed a commit
to Rhahkeem/ohmyzsh
that referenced
this pull request
Oct 3, 2022
wilderjds
pushed a commit
to wilderjds/oh-my-zsh
that referenced
this pull request
Oct 9, 2022
aaronbieber
pushed a commit
to aaronbieber/oh-my-zsh
that referenced
this pull request
Oct 12, 2022
rahdjoudj
pushed a commit
to rahdjoudj/ohmyzsh
that referenced
this pull request
Nov 3, 2022
nbaronov
pushed a commit
to nbaronov/oh-my-zsh
that referenced
this pull request
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
omz will not auto-update on some systems using
curl
, failing at the modified lineStandards checklist:
Changes:
--conect-timeout 2
changed to--connect-timeout 2
Other comments:
This bug (not auto-updating on console start) occurs on a WSL2 Ubuntu distribution where
tools/upgrade.sh
is modified andgit update-index --assume-unchanged tools/upgrade.sh
has executed. Tracing the script,curl
exits unexpectedly. The script functions as expected after the change in the PR.