Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(updater): correct spelling of curl flag #11072

Merged
merged 1 commit into from Jul 26, 2022
Merged

fix(updater): correct spelling of curl flag #11072

merged 1 commit into from Jul 26, 2022

Conversation

PennRobotics
Copy link
Contributor

omz will not auto-update on some systems using curl, failing at the modified line

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open. (searched for 'timeout')
  • I have read the contribution guide and followed all the instructions.
  • The code follows the code style guide detailed in the wiki.
  • The code is mine or it's from somewhere with an MIT-compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.

Changes:

  • --conect-timeout 2 changed to --connect-timeout 2

Other comments:

This bug (not auto-updating on console start) occurs on a WSL2 Ubuntu distribution where tools/upgrade.sh is modified and git update-index --assume-unchanged tools/upgrade.sh has executed. Tracing the script, curl exits unexpectedly. The script functions as expected after the change in the PR.

omz will not auto-update on some systems using `curl`, failing at this line
@ohmyzsh ohmyzsh bot added Area: core Issue or PR related to core parts of the project Area: updater Update subsystem labels Jul 26, 2022
@PennRobotics PennRobotics changed the title Fix spelling of curl flag fix(updater): correct spelling of curl flag Jul 26, 2022
@carlosala
Copy link
Member

@mcornella MERGE ASAP!

@mcornella mcornella merged commit bb6c14c into ohmyzsh:master Jul 26, 2022
@mcornella
Copy link
Member

Thank you for finding this Brian, I apologize for the mistake. In order to solve this for users that have curl installed, they should manually update with omz update.

@PennRobotics PennRobotics deleted the patch-1 branch July 26, 2022 10:16
lesterchan added a commit to lesterchan/oh-my-zsh that referenced this pull request Jul 27, 2022
* upstream/master:
  fix(updater): correct spelling of `curl` flag (ohmyzsh#11072)
emcrisostomo pushed a commit to emcrisostomo/oh-my-zsh that referenced this pull request Aug 25, 2022
tekniklr pushed a commit to tekniklr/oh-my-zsh that referenced this pull request Sep 6, 2022
amkirby pushed a commit to amkirby/oh-my-zsh that referenced this pull request Sep 7, 2022
Rhahkeem pushed a commit to Rhahkeem/ohmyzsh that referenced this pull request Oct 3, 2022
wilderjds pushed a commit to wilderjds/oh-my-zsh that referenced this pull request Oct 9, 2022
aaronbieber pushed a commit to aaronbieber/oh-my-zsh that referenced this pull request Oct 12, 2022
rahdjoudj pushed a commit to rahdjoudj/ohmyzsh that referenced this pull request Nov 3, 2022
nbaronov pushed a commit to nbaronov/oh-my-zsh that referenced this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: core Issue or PR related to core parts of the project Area: updater Update subsystem
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants