Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws): add sso #11075

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(aws): add sso #11075

wants to merge 1 commit into from

Conversation

hans-d
Copy link
Contributor

@hans-d hans-d commented Jul 28, 2022

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • I have read the contribution guide and followed all the instructions.
  • The code follows the code style guide detailed in the wiki.
  • The code is mine or it's from somewhere with an MIT-compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.

@ohmyzsh ohmyzsh bot added the Area: plugin Issue or PR related to a plugin label Jul 28, 2022
@ohmyzsh
Copy link
Contributor

ohmyzsh bot commented Jul 28, 2022

Bleep bloop. I determined that these users own the modified files: @maksyms.

@ketiko
Copy link

ketiko commented Aug 19, 2022

+1

@larson-carter
Copy link
Member

I would like an explanation of the reasoning on how it would handle the actual authorization process? Is it 100% token based and will they ever expire?

@hans-d
Copy link
Contributor Author

hans-d commented Sep 21, 2022

Authorization is done completely via the sso flow:

  • if token is not valid anymore (checked by doing a simple call), it will request a new token. Normally this involves displaying a URL you have to visit and enter some code, which in most cases can be opened automatically in a browser. As a user you still have to confirm the request
  • if token is valid at the time of change, it will continue to use it

if the token becomes invalid/expired, one has to either do aws sso login or "switch" to the same profile. Expiration is tied to the sso settings within aws. (in my cases, sessions get expired)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: plugin Issue or PR related to a plugin
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

None yet

3 participants