Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(termsupport): configurable terminal title patterns & cmdline truncate #11870

Conversation

trinitronx
Copy link
Contributor

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • I have read the contribution guide and followed all the instructions.
  • The code follows the code style guide detailed in the wiki.
  • The code is mine or it's from somewhere with an MIT-compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.
  • [N/A] If the code introduces new aliases, I provide a valid use case for all plugin users down below.

Changes:

  • Configurable terminal title patterns & cmdline truncation

Other comments:

Allow user to set environment variables to override default terminal title patterns, and command line truncation char limit. Fallback to original defaults if any are unset.

@ohmyzsh ohmyzsh bot added the Area: core Issue or PR related to core parts of the project label Sep 1, 2023
@mcornella
Copy link
Member

Hello James, thank you for the contribution.

I've reviewed the PR and I think at this stage we are not looking at getting at such a fine-grained level of customization. Doing so requires a level of hacky-ness that I don't really feel worth it or stylish, and is very coupled with the title logic.

We'll be looking in the future to revise this decision to see if we can improve this somehow. In the meantime, you can redefine the functions yourself in your zshrc file, or disable our solution by setting DISABLE_AUTO_TITLE=true and fully customize your logic while keeping compatibility with the title function.

Thanks again for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: core Issue or PR related to core parts of the project Resolution: wontfix This will not be worked on
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants