Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(systemadmin): use ss instead of netstat when available #11957

Merged
merged 2 commits into from
Oct 11, 2023
Merged

refactor(systemadmin): use ss instead of netstat when available #11957

merged 2 commits into from
Oct 11, 2023

Conversation

mcornella
Copy link
Member

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • I have read the contribution guide and followed all the instructions.
  • The code follows the code style guide detailed in the wiki.
  • The code is mine or it's from somewhere with an MIT-compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.
  • If the code introduces new aliases, I provide a valid use case for all plugin users down below.

Changes:

  • Fix code style
  • Use ss equivalent commands and fall back to netstat if not available

Fixes #10330

@ohmyzsh ohmyzsh bot added Area: plugin Issue or PR related to a plugin Topic: alias Pull Request or issue regarding aliases labels Oct 11, 2023
@mcornella
Copy link
Member Author

Note: I have thoroughly checked the commands before submitting the PR, merging directly.

@mcornella mcornella merged commit 53cb50a into ohmyzsh:master Oct 11, 2023
3 checks passed
@mcornella mcornella deleted the refactor/systemadmin-plugin branch October 11, 2023 18:43
wintmain added a commit to wintmain/ohmyzsh that referenced this pull request Oct 12, 2023
@wintmain
Squashed commit of the following:
dd10879 
commit 7329b2f
Author: Marc Cornellà <marc@mcornella.com>
Date:   Thu Oct 12 11:46:49 2023 +0200

    docs(debian): clarify override behavior for `apt_pref` and `apt_upgr`

    Fixes ohmyzsh#11959

commit 5743198
Author: Preston Button <prestonbutton99@gmail.com>
Date:   Thu Oct 12 04:32:48 2023 -0400

    docs(aliases): fix typo (ohmyzsh#11958)

commit 6768906
Author: sattisumasri <73093486+sattisumasri@users.noreply.github.com>
Date:   Thu Oct 12 00:27:01 2023 +0530

    chore: change headings in README to Title Case (ohmyzsh#11956)

    Co-authored-by: Marc Cornellà <hello@mcornella.com>

commit 408330e
Author: Marc Cornellà <hello@mcornella.com>
Date:   Wed Oct 11 20:44:46 2023 +0200

    ci: remove redundant macos runner for CI tests

    Currently the macOS runner is not needed, as we are only checking
    zsh syntax. We can reactivate it in the future if needed.

commit 53cb50a
Author: Marc Cornellà <marc@mcornella.com>
Date:   Wed Oct 11 20:43:55 2023 +0200

    refactor(systemadmin): use `ss` instead of `netstat` when available (ohmyzsh#11957)

commit fedef5d
Author: Marc Cornellà <hello@mcornella.com>
Date:   Wed Oct 11 19:23:44 2023 +0200

    fix(xcode): open Xcode in current Desk if already open in another (ohmyzsh#10384)

    Fixes ohmyzsh#10384

commit da3b8fc
Author: Lukas Elmer <lukas.elmer@gmail.com>
Date:   Wed Oct 11 18:06:22 2023 +0200

    fix(yarn): output completion entries in UTF-8 (ohmyzsh#11955)

commit b1821a2
Author: Adam Johnson <me@adamj.eu>
Date:   Tue Oct 10 16:56:54 2023 +0100

    fix(git): restore showing patch in `gsts` (ohmyzsh#11951)

commit 38db3e1
Author: Adam Henley <71472057+ajh-sr@users.noreply.github.com>
Date:   Tue Oct 10 07:28:09 2023 +1300

    feat(kind): add plugin for Kind k8s tool (ohmyzsh#9827)

    Co-authored-by: jxlwqq <jxlwqq@gmail.com>
    Co-authored-by: Francesco Ilario <fr.ilario@gmail.com>
    Co-authored-by: Marc Cornellà <hello@mcornella.com>

commit 24b2600
Author: tobi1805 <66414944+tobi1805@users.noreply.github.com>
Date:   Mon Oct 9 18:07:51 2023 +0200

    feat(git): delete squash-merged branches in `gbda` (ohmyzsh#11948)

commit 29b99c2
Author: Marc Cornellà <hello@mcornella.com>
Date:   Mon Oct 9 18:00:17 2023 +0200

    feat(updater): add `background-alpha` update mode (preview) (ohmyzsh#11928)

    NOTE: this feature is in alpha / preview mode, it is not guaranteed to work 100% of the
    time in all cases. If you experience any issues, open an issue or search for an open
    one describing your same situation.

    To use this, use the zstyle update mode settings [1] with the value `background-alpha`:

      zstyle ':omz:update' mode background-alpha

    [1] https://github.com/ohmyzsh/ohmyzsh#getting-updates

commit 30a8a5d
Author: Marc Cornellà <hello@mcornella.com>
Date:   Mon Oct 9 17:53:00 2023 +0200

    fix(rtx): fix `rtx` init procedure (ohmyzsh#11949)

commit b75b01a
Author: Marc Cornellà <hello@mcornella.com>
Date:   Sun Oct 8 20:01:46 2023 +0200

    chore: update README badges

commit 7105e37
Author: DemonKiller <55846983+demonkillerr@users.noreply.github.com>
Date:   Sun Oct 8 14:27:55 2023 +0100

    feat(rtx) Added new polyglot runtime manager (asdf rust clone) (ohmyzsh#11932)

    * add readme.md for rtx
    * add rtx plugin
    * update install info
    * remove redundant slashes

commit ee857e3
Author: Robby Russell <robby@planetargon.com>
Date:   Sun Oct 8 14:05:03 2023 +0200

    Adding operating system compatibility chart

commit 974055f
Author: Robby Russell <robby@planetargon.com>
Date:   Sun Oct 8 13:47:16 2023 +0200

    Adding Mastadon and updating X badge

commit f36c6db
Author: Abhinav <abhinavms@outlook.com>
Date:   Tue Oct 3 00:28:42 2023 +0530

    feat(shell-proxy): allow excluding endpoints with `NO_PROXY` (ohmyzsh#11924)

commit 7400d46
Author: jack <r3jack@gmail.com>
Date:   Tue Oct 3 02:41:18 2023 +0800

    fix(ruby): add missing `-run` in `rserver` alias (ohmyzsh#11913)

commit df80a2d
Author: bretello <bretello@users.noreply.github.com>
Date:   Mon Oct 2 20:41:01 2023 +0200

    feat(vi-mode): copy to clipboard when using `vi-change*` and `vi-yank*` widgets (ohmyzsh#11861)

commit fea4584
Author: HeroCC <HeroCC@users.noreply.github.com>
Date:   Mon Oct 2 14:34:57 2023 -0400

    fix(tmux): don't autostart inside background intelliJ (ohmyzsh#11927)

commit 278bcfc
Author: Thomas Faugier <thomas.faugier@gmail.com>
Date:   Mon Oct 2 20:25:17 2023 +0200

    feat(asdf): load zsh completions instead of bash ones

    Closes ohmyzsh#11143
    Closes ohmyzsh#8779

    Co-authored-by: Carlo Sala <carlosalag@protonmail.com>

commit 27402e2
Author: Jake Conway <Conway@users.noreply.github.com>
Date:   Fri Sep 29 05:24:40 2023 -0500

    docs(gas): update plugin url (ohmyzsh#11918)

commit d3b6f1f
Author: Piotr Minkina <piotrminkina@users.noreply.github.com>
Date:   Thu Sep 28 23:43:06 2023 +0200

    fix(gradle): remove look for settings.gradle files (ohmyzsh#11917)

commit 0e1e877
Author: Carlo Sala <carlosalag@protonmail.com>
Date:   Wed Sep 27 08:19:57 2023 +0200

    fix(git)!: remove `gt` alias

    BREAKING CHANGE: `gt` alias clashes with Graphite CLI
    (https://graphite.dev). See ohmyzsh#11910 (comment)

commit 4fb5d02
Author: Adam Johnson <me@adamj.eu>
Date:   Tue Sep 26 08:31:32 2023 +0100

    feat(git): add reset aliases `grhk` and `grhs` (ohmyzsh#11896)

commit e2b8553
Author: Adam Johnson <me@adamj.eu>
Date:   Tue Sep 26 08:27:48 2023 +0100

    feat(git): add tag aliases `gt` and `gta` (ohmyzsh#11910)

    Co-authored-by: hasecilu <hasecilu@protonmail.com>
    Co-authored-by: Rik <gitaarik@posteo.net>
    Co-authored-by: Carlo Sala <carlosalag@protonmail.com>

commit bca62f7
Author: Adam Johnson <me@adamj.eu>
Date:   Tue Sep 26 08:22:32 2023 +0100

    feat(git): add branch rename alias `gbm` (ohmyzsh#11909)

    Co-authored-by: Gabriel Akinyosoye <gabrielfemi799@gmail.com>

commit aaa7496
Author: Adam Johnson <me@adamj.eu>
Date:   Tue Sep 26 08:18:54 2023 +0100

    fix(git): remove `--text` from `gsts` (ohmyzsh#11897)

commit a17789e
Author: Adam Johnson <me@adamj.eu>
Date:   Mon Sep 25 09:49:22 2023 +0100

    docs(git): improve tables and language (ohmyzsh#11895)

commit c91684b
Author: Carlo Sala <carlosalag@protonmail.com>
Date:   Mon Sep 25 08:20:20 2023 +0100

    docs(web-search): add `youtube` entry

commit 1c55a0f
Author: Marcus Müller <marcus@hostalia.de>
Date:   Thu Sep 21 12:43:00 2023 +0200

    feat(dnf): use `dnf5` if available (ohmyzsh#11904)

    Co-authored-by: Marcus Müller <marcus_ohmyzsh@baseband.digital>

commit 1cc32be
Author: ajatkj <ajatkj@yahoo.co.in>
Date:   Wed Sep 20 20:21:27 2023 +0530

    feat(poetry-env): create plugin (ohmyzsh#11069)

commit 350427d
Author: Trick van Staveren <trick@vanstaveren.us>
Date:   Wed Sep 20 09:09:26 2023 -0500

    feat(hitchhiker): clean up refs to magic string (ohmyzsh#11900)

commit 91cd534
Author: Marc-Antoine Godde <marc-antoine.godde@hotmail.fr>
Date:   Wed Sep 20 12:09:46 2023 +0200

    fix(gcloud): source `path.zsh.inc` always (ohmyzsh#11901)

commit cdd7dab
Author: Marc Cornellà <hello@mcornella.com>
Date:   Sun Sep 17 16:20:46 2023 +0200

    ci(installer): remove `vc link` which generates the wrong project

    `vc link` is not needed, as we already have `VERCEL_PROJECT_ID`
    defined as an env variable. Currently the `vc link` only creates
    a second empty project with the name `installer` as seen in logs:

      Linked to ohmyzsh/installer (created .vercel and added it to .gitignore)
      Vercel CLI 32.2.4
QwertyMax pushed a commit to QwertyMax/ohmyzsh that referenced this pull request Oct 13, 2023
@mcornella @QwertyMax
refactor(systemadmin): use ss instead of netstat when available (o…
ce1a55f 
…hmyzsh#11957)
claudenm pushed a commit to claudenm/ohmyzsh that referenced this pull request Jan 9, 2024
@mcornella @claudenm
refactor(systemadmin): use ss instead of netstat when available (o…
9f9a711 
…hmyzsh#11957)
fdelacruz pushed a commit to fdelacruz/ohmyzsh that referenced this pull request Jan 21, 2024
@mcornella @fdelacruz
refactor(systemadmin): use ss instead of netstat when available (o…
b47a378 
…hmyzsh#11957)
jmussmann pushed a commit to jmussmann/oh-my-zsh that referenced this pull request Feb 17, 2024
@mcornella
refactor(systemadmin): use ss instead of netstat when available (o…
efe0d4c 
…hmyzsh#11957)
lukaselmer pushed a commit to lukaselmer/ohmyzsh that referenced this pull request Apr 16, 2024
@mcornella @lukaselmer
refactor(systemadmin): use ss instead of netstat when available (o…
5ff8f91 
…hmyzsh#11957)
cschuyle pushed a commit to cschuyle/ohmyzsh that referenced this pull request Apr 18, 2024
@mcornella @cschuyle
refactor(systemadmin): use ss instead of netstat when available (o…
b192adb 
…hmyzsh#11957)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: plugin Issue or PR related to a plugin Topic: alias Pull Request or issue regarding aliases
Projects
Main project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

systemadmin: use ss instead of the deprecated netstat
1 participant
@mcornella