-
-
Notifications
You must be signed in to change notification settings - Fork 25.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(git): fix fallback to develop branch if master
not found
#11966
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
It indeed fixes the issue for me.
It might be nice maybe to default to main
instead of master
, seems to be more common nowadays.
I wouldn't recommend hard switching from master to main. |
@LunarWatcher I was talking about the branch name we output if no one is found. |
I'd rather not over-rely on the default here and not introduce a breaking change if it's possible, so I'll merge it directly. Thanks for the review! |
Standards checklist:
Changes:
git_develop_branch
ifgit_main_branch
was not found ingbda
functionOther comments:
Fixes #11964