Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lib): patch omz_urlencode to not encode UTF-8 chars in Termux #12076

Merged
merged 1 commit into from
Dec 6, 2023
Merged

fix(lib): patch omz_urlencode to not encode UTF-8 chars in Termux #12076

merged 1 commit into from
Dec 6, 2023
+5 −0

Conversation

mcornella
Copy link
Member

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • I have read the contribution guide and followed all the instructions.
  • The code follows the code style guide detailed in the wiki.
  • The code is mine or it's from somewhere with an MIT-compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.
  • If the code introduces new aliases, I provide a valid use case for all plugin users down below.

Changes:

  • Termux only has a single UTF-8 locale, so byte-by-byte encoding is not possible. This PR effectively bypasses that so that the resulting URL has the UTF-8 characters directly, which is already possible in URLs.

Fixes #12061

@ohmyzsh ohmyzsh bot added the Area: core Issue or PR related to core parts of the project label Nov 30, 2023
@mcornella mcornella mentioned this pull request Nov 30, 2023
Closed
carlosala
carlosala approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@carlosala carlosala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can merge! 🚀

@mcornella mcornella merged commit 1ae0515 into ohmyzsh:master Dec 6, 2023
2 checks passed
neiljdo added a commit to neiljdo/oh-my-zsh that referenced this pull request Dec 14, 2023
@neiljdo
Merge branch 'master' of https://github.com/ohmyzsh/ohmyzsh
b5a947b 
* 'master' of https://github.com/ohmyzsh/ohmyzsh: (1119 commits)
  feat(dotnet): update completion script (ohmyzsh#12028)
  feat(frontend-search): add `I am lucky` option
  feat(frontend-search): add nextjs
  fix(lib): patch `omz_urlencode` to not encode UTF-8 chars in Termux (ohmyzsh#12076)
  feat(bgnotify): add option to disable terminal bell (ohmyzsh#12077)
  fix(installer): fix path logic and improve clarity on ZDOTDIR use
  refactor(bgnotify): get Sway AppId with `awk` as fallback (ohmyzsh#12062)
  docs: document the off-GitHub installation URL (ohmyzsh#12079)
  ci(installer): fix token passing and only run on main repo
  feat(per-directory-history): add option to reduce verbosity (ohmyzsh#12069)
  fix(misc): only set PAGER if `less` or `more` are available (ohmyzsh#12060)
  fix(robbyrussell): line wrapping for some systems (ohmyzsh#12058)
  fix(python): set `py` alias if `py` is not installed (ohmyzsh#12059)
  feat(docker-compose): add `dclF` alias (ohmyzsh#10603)
  docs(bgnotify): match README with current features (ohmyzsh#12057)
  feat(bgnotify): add icon parameter (ohmyzsh#12055)
  fix(per-directory-history): print toggle message properly (ohmyzsh#10872)
  fix(bgnotify): detect properly if `swaymsg` is installed
  feat(bgnotify): add support to wayland (ohmyzsh#12045)
  fix(juju): add `public-address` fallback to `jaddr` (ohmyzsh#12046)
  ...
lesterchan added a commit to lesterchan/oh-my-zsh that referenced this pull request Dec 26, 2023
@lesterchan
Merge remote-tracking branch 'upstream/master'
ba7819b 
* upstream/master: (96 commits)
  feat(react-native): add aliases for iPhone 15 (ohmyzsh#12114)
  fix(bgnotify): make it work with `set -e` (ohmyzsh#12111)
  fix(changelog): use longer hashes for commits (ohmyzsh#12096)
  fix(rake-fast): make `.rake_tasks` write atomic (ohmyzsh#12108)
  ci(dependencies): fix typo
  ci(dependencies): add automation for updating external dependencies (ohmyzsh#12109)
  feat(dotnet): update completion script (ohmyzsh#12028)
  feat(frontend-search): add `I am lucky` option
  feat(frontend-search): add nextjs
  fix(lib): patch `omz_urlencode` to not encode UTF-8 chars in Termux (ohmyzsh#12076)
  feat(bgnotify): add option to disable terminal bell (ohmyzsh#12077)
  fix(installer): fix path logic and improve clarity on ZDOTDIR use
  refactor(bgnotify): get Sway AppId with `awk` as fallback (ohmyzsh#12062)
  docs: document the off-GitHub installation URL (ohmyzsh#12079)
  ci(installer): fix token passing and only run on main repo
  feat(per-directory-history): add option to reduce verbosity (ohmyzsh#12069)
  fix(misc): only set PAGER if `less` or `more` are available (ohmyzsh#12060)
  fix(robbyrussell): line wrapping for some systems (ohmyzsh#12058)
  fix(python): set `py` alias if `py` is not installed (ohmyzsh#12059)
  feat(docker-compose): add `dclF` alias (ohmyzsh#10603)
  ...
fklassen added a commit to fklassen/ohmyzsh that referenced this pull request Dec 29, 2023
@fklassen
Merge remote-tracking branch 'upstream/master'
c876a57 
* upstream/master: (237 commits)
  feat(z): update to version afaf2965 (ohmyzsh#12136)
  feat(gitfast): update to version v2.0 (ohmyzsh#12135)
  ci(project): use ohmyzsh's bot credentials
  ci(dependencies): fix some envs and add requirements
  feat(git): add `gcB` alias (ohmyzsh#12116)
  feat(aws): add support for sso sessions login (ohmyzsh#12090)
  feat(aws): add sso logout capabilities (ohmyzsh#12113)
  fix(bgnotify): don't require accessibility perms in macos (ohmyzsh#11433)
  fix(nvm): prevent duplicates in lazy_cmd
  feat(react-native): add aliases for iPhone 15 (ohmyzsh#12114)
  fix(bgnotify): make it work with `set -e` (ohmyzsh#12111)
  fix(changelog): use longer hashes for commits (ohmyzsh#12096)
  fix(rake-fast): make `.rake_tasks` write atomic (ohmyzsh#12108)
  ci(dependencies): fix typo
  ci(dependencies): add automation for updating external dependencies (ohmyzsh#12109)
  feat(dotnet): update completion script (ohmyzsh#12028)
  feat(frontend-search): add `I am lucky` option
  feat(frontend-search): add nextjs
  fix(lib): patch `omz_urlencode` to not encode UTF-8 chars in Termux (ohmyzsh#12076)
  feat(bgnotify): add option to disable terminal bell (ohmyzsh#12077)
  ...

# Conflicts:
#	README.md
@mcornella mcornella deleted the fix/termux-urlencode branch January 2, 2024 15:43
fdelacruz pushed a commit to fdelacruz/ohmyzsh that referenced this pull request Jan 21, 2024
@mcornella @fdelacruz
fix(lib): patch omz_urlencode to not encode UTF-8 chars in Termux (o…
0bf956d 
…hmyzsh#12076)

Fixes ohmyzsh#12061
jmussmann pushed a commit to jmussmann/oh-my-zsh that referenced this pull request Feb 17, 2024
@mcornella
fix(lib): patch omz_urlencode to not encode UTF-8 chars in Termux (o…
aa6a643 
…hmyzsh#12076)

Fixes ohmyzsh#12061
pull bot pushed a commit to kis87988/ohmyzsh that referenced this pull request Mar 27, 2024
@mcornella @pull
fix(lib): patch omz_urlencode to not encode UTF-8 chars in Termux (o…
aa4bf0e 
…hmyzsh#12076)

Fixes ohmyzsh#12061
lukaselmer pushed a commit to lukaselmer/ohmyzsh that referenced this pull request Apr 16, 2024
@mcornella @lukaselmer
fix(lib): patch omz_urlencode to not encode UTF-8 chars in Termux (o…
df0acb7 
…hmyzsh#12076)

Fixes ohmyzsh#12061
cschuyle pushed a commit to cschuyle/ohmyzsh that referenced this pull request Apr 18, 2024
@mcornella @cschuyle
fix(lib): patch omz_urlencode to not encode UTF-8 chars in Termux (o…
200173a 
…hmyzsh#12076)

Fixes ohmyzsh#12061
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosala carlosala carlosala approved these changes

Assignees
No one assigned
Labels
Area: core Issue or PR related to core parts of the project
Projects
Main project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

web-search baidu 你好
2 participants
@mcornella @carlosala