Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gitfast): remove update script #12262

Merged
merged 5 commits into from Mar 7, 2024
Merged

chore(gitfast): remove update script #12262

merged 5 commits into from Mar 7, 2024

Conversation

felipec
Copy link
Contributor

@felipec felipec commented Mar 6, 2024

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • I have read the contribution guide and followed all the instructions.
  • The code follows the code style guide detailed in the wiki.
  • The code is mine or it's from somewhere with an MIT-compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.
  • If the code introduces new aliases, I provide a valid use case for all plugin users down below.

Changes:

  • General update

Other comments:

I've removed the update script since it seems a GitHub action is already taking care of the updating. I also updated the plug-in standard code to match upstream. And I removed the aliases section in the readme, since it only applies to ancient versions of oh-my-zsh.

@felipec
feat(gitfast): update version
3d2a611 
According to the `dependencies.yml` file.
@felipec
feat(gitfast): remove update script
2a32368 
It seems the update steps are happening automatically now.
@felipec
feat(gitfast): update README
a283088 
The aliases have been orthogonal for a while now.
@felipec
feat(gitfast): update plugin script
6b42361 
This is the latest version.
@ohmyzsh ohmyzsh bot added Area: plugin Issue or PR related to a plugin Type: documentation Documentation issue or Pull Request labels Mar 6, 2024
carlosala
carlosala approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@carlosala carlosala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carlosala carlosala changed the title feat(gitfast): update chore(gitfast): remove update script Mar 7, 2024
@carlosala carlosala merged commit 2a71aa5 into ohmyzsh:master Mar 7, 2024
2 checks passed
@carlosala
Copy link
Member

Thanks!

lesterchan added a commit to lesterchan/oh-my-zsh that referenced this pull request Mar 16, 2024
@lesterchan
Merge remote-tracking branch 'upstream/master'
33425b6 
* upstream/master: (90 commits)
  feat(gradle): update completion to version 25da917c (ohmyzsh#12287)
  fix(dependencies): copy gradle LICENSE
  feat(dependencies): enable gradle plugin
  docs: fix typos (ohmyzsh#12284)
  docs(pyenv): fix typo (ohmyzsh#12283)
  feat(extract): prefer using `pbzip2` instead of `bunzip2` (ohmyzsh#12280)
  docs(readme): add contributor list (ohmyzsh#12236)
  feat(fzf): add default fzf_base for msys2 (ohmyzsh#12274)
  fix(async): register the git prompt async handler correctly (ohmyzsh#12267)
  fix(git): disable temporarely async prompt
  feat(async)!: implement async prompt API and apply to git prompt (ohmyzsh#12257)
  feat(tools): update `supports_hyperlinks` (ohmyzsh#12258)
  chore(gitfast): remove update script (ohmyzsh#12262)
  perf(nvm): don't call `nvm version` on every cd
  feat(nvm)!: make `lazy` and `autoload` options compatible
  fix(nvm): remove zsh completion
  fix(terraform): fix completion repeating flags with value (ohmyzsh#12256)
  fix(terraform): pass `-chdir` to completion commands (ohmyzsh#12254)
  feat(python): add auto venv activation (ohmyzsh#12248)
  feat(terraform): update completion to `v1.7` (ohmyzsh#12252)
  ...
gerardo pushed a commit to gerardo/oh-my-zsh that referenced this pull request Mar 19, 2024
Merge remote-tracking branch 'upstream/master'
e7987ee 
* upstream/master: (212 commits)
  fix(docker-compose): completion regression (ohmyzsh#12288)
  feat(gradle): update completion to version 25da917c (ohmyzsh#12287)
  fix(dependencies): copy gradle LICENSE
  feat(dependencies): enable gradle plugin
  docs: fix typos (ohmyzsh#12284)
  docs(pyenv): fix typo (ohmyzsh#12283)
  feat(extract): prefer using `pbzip2` instead of `bunzip2` (ohmyzsh#12280)
  docs(readme): add contributor list (ohmyzsh#12236)
  feat(fzf): add default fzf_base for msys2 (ohmyzsh#12274)
  fix(async): register the git prompt async handler correctly (ohmyzsh#12267)
  fix(git): disable temporarely async prompt
  feat(async)!: implement async prompt API and apply to git prompt (ohmyzsh#12257)
  feat(tools): update `supports_hyperlinks` (ohmyzsh#12258)
  chore(gitfast): remove update script (ohmyzsh#12262)
  perf(nvm): don't call `nvm version` on every cd
  feat(nvm)!: make `lazy` and `autoload` options compatible
  fix(nvm): remove zsh completion
  fix(terraform): fix completion repeating flags with value (ohmyzsh#12256)
  fix(terraform): pass `-chdir` to completion commands (ohmyzsh#12254)
  feat(python): add auto venv activation (ohmyzsh#12248)
  ...
keenahn added a commit to keenahn/oh-my-zsh that referenced this pull request Mar 22, 2024
@keenahn
merge: branch 'master' into ktj/v1.2
754ae95 
* master: (223 commits)
  fix(mise): update environment when loading the plugin (ohmyzsh#12294)
  fix(docker-compose): completion regression (ohmyzsh#12288)
  feat(gradle): update completion to version 25da917c (ohmyzsh#12287)
  fix(dependencies): copy gradle LICENSE
  feat(dependencies): enable gradle plugin
  docs: fix typos (ohmyzsh#12284)
  docs(pyenv): fix typo (ohmyzsh#12283)
  feat(extract): prefer using `pbzip2` instead of `bunzip2` (ohmyzsh#12280)
  docs(readme): add contributor list (ohmyzsh#12236)
  feat(fzf): add default fzf_base for msys2 (ohmyzsh#12274)
  fix(async): register the git prompt async handler correctly (ohmyzsh#12267)
  fix(git): disable temporarely async prompt
  feat(async)!: implement async prompt API and apply to git prompt (ohmyzsh#12257)
  feat(tools): update `supports_hyperlinks` (ohmyzsh#12258)
  chore(gitfast): remove update script (ohmyzsh#12262)
  perf(nvm): don't call `nvm version` on every cd
  feat(nvm)!: make `lazy` and `autoload` options compatible
  fix(nvm): remove zsh completion
  fix(terraform): fix completion repeating flags with value (ohmyzsh#12256)
  fix(terraform): pass `-chdir` to completion commands (ohmyzsh#12254)
  ...
fdelacruz pushed a commit to fdelacruz/ohmyzsh that referenced this pull request Mar 27, 2024
@felipec @carlosala @fdelacruz
chore(gitfast): remove update script (ohmyzsh#12262)
4e9acdd 
Co-authored-by: Carlo Sala <carlosalag@protonmail.com>
pull bot pushed a commit to kis87988/ohmyzsh that referenced this pull request Mar 27, 2024
@felipec @carlosala @pull
chore(gitfast): remove update script (ohmyzsh#12262)
968ae64 
Co-authored-by: Carlo Sala <carlosalag@protonmail.com>
lukaselmer pushed a commit to lukaselmer/ohmyzsh that referenced this pull request Apr 16, 2024
@felipec @carlosala @lukaselmer
chore(gitfast): remove update script (ohmyzsh#12262)
608d5e3 
Co-authored-by: Carlo Sala <carlosalag@protonmail.com>
cschuyle pushed a commit to cschuyle/ohmyzsh that referenced this pull request Apr 18, 2024
@felipec @carlosala @cschuyle
chore(gitfast): remove update script (ohmyzsh#12262)
dba9818 
Co-authored-by: Carlo Sala <carlosalag@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosala carlosala carlosala approved these changes

Assignees
No one assigned
Labels
Area: plugin Issue or PR related to a plugin Type: documentation Documentation issue or Pull Request
Projects
Main project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@felipec @carlosala