Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jj): add jujutsu plugin #12292

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

nasso
Copy link

@nasso nasso commented Mar 21, 2024

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • I have read the contribution guide and followed all the instructions.
  • The code follows the code style guide detailed in the wiki.
  • The code is mine or it's from somewhere with an MIT-compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.
  • If the code introduces new aliases, I provide a valid use case for all plugin users down below.

Changes:

  • adds new plugin: jj
  • adds completions for jj
  • adds jj_prompt_template to easily make prompts (escapes %s)
  • adds jj_prompt_template_raw to easily make colored prompts (does not escape %s)
  • adds ZSH_THEME_JJ_IGNORE_WORKING_COPY to enable/disable passing --ignore-working-copy to jj when using jj_prompt_template(_raw). Disabled by default: --ignore-working-copy will not be passed and jj_prompt_template(_raw) will always return up-to-date information, which may be a little slower.
  • adds some aliases (they try to follow existing git aliases where it makes sense)

Other comments:

maybe some themes could be patched or new ones added? i linked to a patch i made for myself of the sunaku theme that can serve as an example

@ohmyzsh ohmyzsh bot added Area: plugin Issue or PR related to a plugin Type: documentation Documentation issue or Pull Request New: plugin Request for a plugin or Pull Request that adds one labels Mar 21, 2024
@nasso nasso force-pushed the push-kqrrptyxyzxq branch 4 times, most recently from 57928eb to 7645384 Compare March 21, 2024 14:07
@ohmyzsh ohmyzsh bot added the Topic: alias Pull Request or issue regarding aliases label Apr 23, 2024
@nasso nasso changed the title feat(jj): completions and prompt utils feat(jj): add jujutsu plugin Apr 23, 2024
@nasso nasso force-pushed the push-kqrrptyxyzxq branch 2 times, most recently from e8bea0b to 294c673 Compare April 27, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: plugin Issue or PR related to a plugin New: plugin Request for a plugin or Pull Request that adds one Topic: alias Pull Request or issue regarding aliases Type: documentation Documentation issue or Pull Request
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

None yet

1 participant