Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(laravel): add artisan test alias (pats) #12310

Merged
merged 3 commits into from Apr 8, 2024
Merged

feat(laravel): add artisan test alias (pats) #12310

merged 3 commits into from Apr 8, 2024

Conversation

rezsk
Copy link
Contributor

@rezsk rezsk commented Mar 30, 2024

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • I have read the contribution guide and followed all the instructions.
  • The code follows the code style guide detailed in the wiki.
  • The code is mine or it's from somewhere with an MIT-compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.
  • If the code introduces new aliases, I provide a valid use case for all plugin users down below.

Changes:

  • Added pat alias for php artisan test into Laravel plugin.

Other comments:

Since running tests is one of the most repetitive tasks in TDD flow, I think it would be nice to have this alias.

@ohmyzsh ohmyzsh bot added Area: plugin Issue or PR related to a plugin Topic: alias Pull Request or issue regarding aliases Type: documentation Documentation issue or Pull Request labels Mar 30, 2024
@rezsk
Copy link
Contributor Author

rezsk commented Mar 30, 2024

@zeshan77 I would be thankful if you review this change.

@rezsk rezsk changed the title Add alias for artisan test command into Laravel plugin Added alias for artisan test command into Laravel plugin Mar 30, 2024
@ghonche
Copy link

ghonche commented Mar 30, 2024

So useful. I need this to be merged 👍🏻

@carlosala carlosala self-assigned this Apr 4, 2024
carlosala
carlosala requested changes Apr 4, 2024
View reviewed changes
Copy link
Member

@carlosala carlosala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like pat is already a command in some systems. Could you change it to pate or pats?

@rezsk rezsk requested a review from carlosala April 8, 2024 05:58
@carlosala carlosala changed the title Added alias for artisan test command into Laravel plugin feat(laravel): add artisan test alias (pats) Apr 8, 2024
@carlosala carlosala merged commit 982ea72 into ohmyzsh:master Apr 8, 2024
1 check passed
@carlosala
Copy link
Member

Thanks for your contribution!

lukaselmer pushed a commit to lukaselmer/ohmyzsh that referenced this pull request Apr 16, 2024
@rezsk @lukaselmer
feat(laravel): add artisan test alias (pats) (ohmyzsh#12310)
8817ea2
cschuyle pushed a commit to cschuyle/ohmyzsh that referenced this pull request Apr 18, 2024
@rezsk @cschuyle
feat(laravel): add artisan test alias (pats) (ohmyzsh#12310)
08632d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosala carlosala carlosala approved these changes

Assignees

@carlosala carlosala

Labels
Area: plugin Issue or PR related to a plugin Topic: alias Pull Request or issue regarding aliases Type: documentation Documentation issue or Pull Request
Projects
Main project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rezsk @ghonche @carlosala