Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dependencies): add wd #12405

Merged
merged 2 commits into from May 9, 2024
Merged

feat(dependencies): add wd #12405

merged 2 commits into from May 9, 2024

Conversation

alpha-tango-kilo
Copy link
Contributor

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • I have read the contribution guide and followed all the instructions.
  • The code follows the code style guide detailed in the wiki.
  • The code is mine or it's from somewhere with an MIT-compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.
  • If the code introduces new aliases, I provide a valid use case for all plugin users down below.

Changes:

Other comments:

Are the changes made in 2d32e9b still required? They were never contributed upstream so my simple copy-paste from the wd repo has overwritten them

@ohmyzsh ohmyzsh bot added Area: plugin Issue or PR related to a plugin Topic: bindkey Pull Request or issue regarding keyboard shortcuts Type: documentation Documentation issue or Pull Request Topic: completion Pull Request or issue regarding completion labels May 8, 2024
@carlosala
Copy link
Member

carlosala commented May 8, 2024 •
edited

@alpha-tango-kilo I'd rather keep that $0 stuff, it's nice to keep the standards alive, could you upstream that? You could as well upstream all those trailing whitespace that some housekeeping PR removed.
If you can release v0.6.1, it'd be amazing!
We could add wd to our dependency system to automatically update them when new releases appear.

@carlosala carlosala self-assigned this May 8, 2024
@alpha-tango-kilo
Copy link
Contributor Author

alpha-tango-kilo commented May 8, 2024 •
edited

I'll get those two bits upstreamed for you, no worries!

Update: upstreamed and v0.6.1 released on the wd repo. What's next?

We could add wd to our dependency system to automatically update them when new releases appear

Sounds great, how do we make that work?

@alpha-tango-kilo alpha-tango-kilo marked this pull request as draft May 8, 2024 20:10
@carlosala
Copy link
Member

You can add an entry similar to this one by choosing the needed files. Here you have an example for tag-based versioning. You can create the entry with v0.6.0 to trigger the updater the first time.

@ohmyzsh ohmyzsh bot removed Area: plugin Issue or PR related to a plugin Topic: bindkey Pull Request or issue regarding keyboard shortcuts Topic: completion Pull Request or issue regarding completion labels May 9, 2024
@alpha-tango-kilo
Copy link
Contributor Author

I think I've done that correctly - how does that look?

@alpha-tango-kilo alpha-tango-kilo marked this pull request as ready for review May 9, 2024 14:23
@alpha-tango-kilo alpha-tango-kilo changed the title Update wd to v0.6.0 Setup the wd plugin to auto-update May 9, 2024
@carlosala carlosala changed the title Setup the wd plugin to auto-update feat(dependencies): add wd May 9, 2024
@carlosala carlosala merged commit 5947c3c into ohmyzsh:master May 9, 2024
2 checks passed
@carlosala
Copy link
Member

Thanks!

@alpha-tango-kilo alpha-tango-kilo deleted the update-wd branch May 10, 2024 09:45
lesterchan added a commit to lesterchan/oh-my-zsh that referenced this pull request May 11, 2024
@lesterchan
Merge remote-tracking branch 'upstream/master'
0514368 
* upstream/master: (58 commits)
  fix(git): add checked-out branch support to `gbg*` (ohmyzsh#12397)
  feat(procs): add completions plugin (ohmyzsh#12406)
  fix(nvm): use `command cat` to avoid alias (ohmyzsh#12410)
  fix(nvm): use `nvm version` when needed (ohmyzsh#12409)
  feat(dependencies): add `wd` (ohmyzsh#12405)
  fix(cli): fix edge cases in `omz plugin disable` command (ohmyzsh#12401)
  feat(nvm): add `corepack` to `lazy_cmd`
  feat(python): autovenv keeps activated on subdirs (ohmyzsh#12396)
  fix(extract): `zst` now extracts as expected (ohmyzsh#12395)
  feat(termsupport): support `alacritty*` TERM (ohmyzsh#12392)
  feat(autojump): add `nix-darwin` install path (ohmyzsh#12389)
  fix(fzf): support old `fzf` versions
  fix(copybuffer): prevent `which` alias usage (ohmyzsh#12379)
  fix(poetry-env): do not deactivate in a subdir
  feat(fishy): add color to username (ohmyzsh#12369)
  fix(ssh-agent): add identity only if identity exists (ohmyzsh#12371)
  chore(async): reenable async prompt by default on zsh < 5.0.6 (ohmyzsh#12358)
  fix(async): fix crash on zsh < 5.0.6 (ohmyzsh#12358)
  feat(fzf): support fzf setup for 0.48.0 and older (ohmyzsh#12367)
  fix(history): add `t` option to history wrapper (ohmyzsh#12365)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosala carlosala carlosala approved these changes

Assignees

@carlosala carlosala

Labels
Type: documentation Documentation issue or Pull Request
Projects
Main project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alpha-tango-kilo @carlosala