Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: service and service account aliases (Breaking change) #12462

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alelb22
Copy link

@alelb22 alelb22 commented May 29, 2024

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • I have read the contribution guide and followed all the instructions.
  • The code follows the code style guide detailed in the wiki.
  • The code is mine or it's from somewhere with an MIT-compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.
  • If the code introduces new aliases, I provide a valid use case for all plugin users down below.

Changes:

This PR modifies how the services related aliases work, with the aim of standardizing them and allowing the usage of new aliases for service accounts, as they were overlapping. It's a breaking change since kgs, kgsw, kgswide, kes, kds, and kdels aliases are removed, and kgsa is now used to get service accounts information instead of services information.

Other comments:

New aliases:

# Service management.
alias kgsvc='kubectl get svc'
alias kgsvca='kubectl get svc --all-namespaces'
alias kgsvcw='kgsvc --watch'
alias kgsvcwide='kgsvc -o wide'
alias kesvc='kubectl edit svc'
alias kdsvc='kubectl describe svc'
alias kdelsvc='kubectl delete svc'

# Service account management.
alias kgsa="kubectl get sa"
alias kgsaa="kubectl get sa --all-namespaces"
alias kgsaw="kgsa --watch"
alias kgsawide="kgsa -o wide"
alias kesa="kubectl edit sa"
alias kdsa="kubectl describe sa"
alias kdelsa="kubectl delete sa"

@ohmyzsh ohmyzsh bot added Area: plugin Issue or PR related to a plugin Topic: alias Pull Request or issue regarding aliases labels May 29, 2024
@ohmyzsh ohmyzsh bot added the Type: documentation Documentation issue or Pull Request label May 30, 2024
@robbyrussell robbyrussell added the Status: testers needed Pull Requests that are waiting for testers to merge label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: plugin Issue or PR related to a plugin Status: testers needed Pull Requests that are waiting for testers to merge Topic: alias Pull Request or issue regarding aliases Type: documentation Documentation issue or Pull Request
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

None yet

2 participants