Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eza): add icons option #12469

Merged
merged 8 commits into from
Jun 4, 2024
Merged

feat(eza): add icons option #12469

merged 8 commits into from
Jun 4, 2024

Conversation

EraPartner
Copy link
Contributor

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • I have read the contribution guide and followed all the instructions.
  • The code follows the code style guide detailed in the wiki.
  • The code is mine or it's from somewhere with an MIT-compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.
  • If the code introduces new aliases, I provide a valid use case for all plugin users down below.

Changes:

  • Give the possibility to display icons with eza command

@ohmyzsh ohmyzsh bot added the Area: plugin Issue or PR related to a plugin label Jun 2, 2024
@ohmyzsh ohmyzsh
Copy link
Contributor

ohmyzsh bot commented Jun 2, 2024

Bleep bloop. I determined that these users own the modified files: @pepoluan.

carlosala
carlosala approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@carlosala carlosala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

carlosala
carlosala requested changes Jun 3, 2024
View reviewed changes
Copy link
Member

@carlosala carlosala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add readme information? Thanks!

@carlosala carlosala self-assigned this Jun 3, 2024
@ohmyzsh ohmyzsh bot added the Type: documentation Documentation issue or Pull Request label Jun 3, 2024
@EraPartner
Copy link
Contributor Author

Added documentation! Sorry for all the tests, ssh wasn't verifying

@carlosala carlosala changed the title feat(eza): add support for eza icons option feat(eza): add icons option Jun 4, 2024
@carlosala carlosala merged commit 228d44d into ohmyzsh:master Jun 4, 2024
1 check passed
@carlosala
Copy link
Member

Thanks for the contribution!

@martinbjeldbak martinbjeldbak mentioned this pull request Jun 7, 2024
Merged
8 tasks
yogeshraja pushed a commit to yogeshraja/ohmyzsh that referenced this pull request Jun 26, 2024
@EraPartner
feat(eza): add icons option (ohmyzsh#12469)
019c9b3 
Co-authored-by: Computer <computer@MAI.local>
ttelford pushed a commit to ttelford/oh-my-zsh that referenced this pull request Jun 26, 2024
@EraPartner @ttelford
feat(eza): add icons option (ohmyzsh#12469)
ab814d2 
Co-authored-by: Computer <computer@MAI.local>
naveen-u pushed a commit to naveen-u/ohmyzsh that referenced this pull request Jul 1, 2024
@EraPartner @naveen-u
feat(eza): add icons option (ohmyzsh#12469)
352c70f 
Co-authored-by: Computer <computer@MAI.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosala carlosala carlosala approved these changes

Assignees

@carlosala carlosala

Labels
Area: plugin Issue or PR related to a plugin Type: documentation Documentation issue or Pull Request
Projects
Main project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EraPartner @carlosala