Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest per-directory-history #1635

Merged
merged 2 commits into from Apr 19, 2014

Conversation

jimhester
Copy link
Contributor

See [https://github.com/jimhester/per-directory-history] for changes

@mcornella
Copy link
Member

👍 Fixes #2263

@mcornella
Copy link
Member

Hey I was having a look at this and saw that you separated the .plugin.zsh from the main file. What's wrong with putting it all in one file? It would make the PR cleaner

@jimhester
Copy link
Contributor Author

I did it that way because standalone zsh scripts don't typically have
.plugin.zsh as their suffix. Since the script can be used standalone and
not only as a plugin I wanted to preserve the original name. I was
following the convention used by the (history substring search)[
https://github.com/robbyrussell/oh-my-zsh/tree/master/plugins/history-substring-search]
plugin.

On Fri, Mar 14, 2014 at 8:12 AM, Marc Cornellà notifications@github.comwrote:

Hey I was having a look at this and saw that you separated the .plugin.zshfrom the main file. What's wrong with putting it all in one file? It would
make the PR cleaner


Reply to this email directly or view it on GitHubhttps://github.com//pull/1635#issuecomment-37640831
.

@mcornella
Copy link
Member

cc @robbyrussell, this is cool to be merged. Fixes issue #2263 and even provides a cool README file.

@Kriechi
Copy link
Contributor

Kriechi commented Apr 5, 2014

Any ETA on merging this in?
I think it was reviewed long enough 😄

@jimhester maybe you could rebase & squash the commits.

@Kriechi Kriechi mentioned this pull request Apr 5, 2014
robbyrussell added a commit that referenced this pull request Apr 19, 2014
Update to latest per-directory-history
@robbyrussell robbyrussell merged commit eafd5f3 into ohmyzsh:master Apr 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants