git_prompt_status() slows down zsh with big git repositories #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… set. This is very useful for big repositories where "git status" is very slow.
|
ping ^^ |
|
Merged this into my own master branch |
|
@rperier Can you rebase this for me? |
|
Closing with #2270. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you use a theme which uses the git plugin (like fishy), the prompt generation is very slow and sometimes it takes 2-3s to display the prompt. Even if you set the option "oh-my-zsh.hide-status" thought git config, it's slow. After some tests, I found that "git status" is the problem. It is actually used in git_prompt_status() to get the status of the current working tree and update the prompt.
I propose to don't update the prompt when the option "oh-my-zsh.hide-status" is set, it would be very useful for important git repositories (like qtbase on gitorious)