Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove foreman from the bundler plugin #1825

Closed
wants to merge 1 commit into from
Closed

Conversation

defvol
Copy link

@defvol defvol commented May 16, 2013

"foreman is not part of the bundle"

Fixes rbenv/bundler conflict with foreman by removing the latter from bundler.plugin.zsh

"foreman is not part of the bundle"

Fixes rbenv/bundler conflict with foreman by removing the latter from bundler.plugin.zsh
@marcroberts
Copy link

+1 for this. Using foreman via the Heroku Toolbelt also causes this problem

@williamhc
Copy link

+1

@rposborne
Copy link

This should be pulled as it's also the opinion of foreman's creator. ddollar/foreman@75b046f

@stephanvane
Copy link

+1
Running foreman bundled causes problems:

  1. I have to include foreman in my gemfile, which the author advises agains: Ruby users should take care not to install foreman in their project's Gemfile.
  2. I have to include other applications (like mailcatcher) to the Gemfile, because they are being run with bundler as well now.

edit:
A workaround for this is to use UNBUNDLED_COMMANDS=(foreman)

(mentioned by erickrause in an other issue: #1817 (comment))

@Kriechi Kriechi mentioned this pull request Jul 2, 2014
Kriechi pushed a commit to Kriechi/oh-my-zsh that referenced this pull request Jul 15, 2014
gbastkowski pushed a commit to gbastkowski/oh-my-zsh that referenced this pull request Jul 20, 2014
LucasRoesler pushed a commit to LucasRoesler/oh-my-zsh that referenced this pull request Jul 22, 2014
cristim pushed a commit to cristim/oh-my-zsh that referenced this pull request Jul 30, 2014
riccardomerolla pushed a commit to riccardomerolla/oh-my-zsh that referenced this pull request Aug 8, 2014
erwinvaneijk pushed a commit to erwinvaneijk/oh-my-zsh that referenced this pull request Sep 8, 2014
stephdewit pushed a commit to stephdewit/oh-my-zsh that referenced this pull request Oct 18, 2014
benjaoming pushed a commit to benjaoming/oh-my-zsh that referenced this pull request Nov 28, 2014
kenton pushed a commit to kenton/oh-my-zsh that referenced this pull request Jan 9, 2015
NobbZ pushed a commit to NobbZ/oh-my-zsh that referenced this pull request May 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants