Micro-optimize lib/git.zsh #1914
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we pre-define POST_GIT_1_7_2 then we can skip out on an extra call to `git version`.
If neither DIRTY nor CLEAN is defined then this function is a noop, so check up-front before making the call. This speeds up prompts that empty out these values.
Use the `git rev-list` plumbing instead of `git log`, which allows us to do without grep. Limit the history to one commit as well.
The original code hard-coded 'origin' as the remote and called
current_branch() to get the corresponding remote branch name,
which may not necessarily be the correct upstream branch.
Use the the built-in @{upstream} syntax instead of calling
current_branch().
This improves performance and fixes a bug when the local and
remote branches do not have the same name.
Avoid looking for dirty submodules when git >= 1.7.2 using the --ignore-submodules=dirty option. Avoid looking at untracked files and other types of files when the theme does not display them. This dramatically speeds up performance.
mcornella
added
Area: core
|
(Obsolete) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.