fix(tools/check_for_upgrade): Don't source profile

[feltnerm]

Reverts #2296, but mostly #1883.

There is no need to source ~/.profile when this script is read. oh-my-zsh writes no configuration data in ~/.profile.

If the user wishes to use data within ~/.profile, then they should source it in another place.

Fixes #2315
Fixes #1509
Fixes #1898

[mcornella]

I support this, issues #1509 and #1898 have failed because of that. Granted, those people's configurations are weird and mistakes in general. But it is not necessary and can generate problems if it's executed via oh-my-zsh autoupdate..
What do you say @stibbons (from #1883), can you manage to setup your proxy config any other way?

[mcornella]

Related issue #2315 and maybe #2428. What do you say @ncanceill?

[feltnerm]

👍

@mcornella, I still kinda can't believe that #1883 was merged in in the first place...

[ncanceill]

I agree, ~/.profile should be sourced directly by the user, probably in their ~/.zshrc. This should mitigate many configuration errors, because many OMZ users switched from bash/ksh to zsh at the same time they installed OMZ.

[mcornella]

Hi @feltnerm, issues #1509 and #1898 are both happening because of sourcing .profile, so this PR will fix them. Can you add this to your PR description?

Fixes #1509
Fixes #1898

[feltnerm]

@mcornella -- what's the best way for me to do that? Will just adding them to the description automatically close them, or do they need to be in the actual commit message?

[mcornella]

Yes, adding to the description of a PR will close them. I made some experiments regarding that, so I know what I'm talking about 😁

[feltnerm]

Awesome, good work! Updated the description.

[mcornella]

Cool thanks!

[feltnerm]

Yay 😀 thanks for your hard work everyone!