Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate if its a git repository or not before triggering git commands. #2884

Closed
wants to merge 1 commit into from

Conversation

rhoml
Copy link

@rhoml rhoml commented Jun 16, 2014

closes #2883

@ncanceill
Copy link
Contributor

Thanks for the fix — which needs testing.

It is good practice to notify the original developers of the theme/plugin/thingy that you want to update, like so:
@dlobraico @pilif

@mcornella
Copy link
Member

This might be a good time to discuss #2317 and #2321.
/CC @richardtsai @haneefmubarak

@haneefmubarak
Copy link

...how do #2317 and #2321 relate to this?

@mcornella
Copy link
Member

This modifies the pygmalion theme

@dlobraico
Copy link
Contributor

Thanks for the notification @ncanceill, sounds good to me.

@ncanceill
Copy link
Contributor

Cool! So this looks nice, but @rhoml please try to look into other PRs related to the pygmalion theme, and to aggregate the changes.

@mcornella
Copy link
Member

Hey all, this method to check if we're in a git repository was seen to be buggy. See #1504 and #3091.
Please close

@rhoml rhoml closed this Oct 26, 2014
@rhoml rhoml deleted the fix-git-bug branch October 26, 2014 17:01
@webknjaz
Copy link

In fact, this check doesn't take into account that user may have a --separate-git-dir. And in this case it would be a file containing a reference, like: gitdir: /path/to/real/repo

https://git-scm.com/docs/git-clone#git-clone---separate-git-dirltgitdirgt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fatal: Invalid gitfile format: .git
6 participants