allow overriding lib/*.zsh in custom/lib

[wrboyce]

Simple change which has been submitted before and closed without explanation… Can we get this discussion going again?

refs #1369 #2762 and possibly #1579 #2172 #2450!

Would really like to see this, or a similar feature, merged.

[wrboyce]

Heeelloooooooooo?!

[robbyrussell]

Would like some testers for this. One concern about this would be on start performance (as that's been a concern of our users... so if we add something to check for each config file then check for a custom file that overrides it... what's the latency we'll be introducing?

Some before and after speed tests might be nice

[wrboyce]

I'm not sure how precise these timing tests are, but here goes:

Using this branch and my custom directory.

major:~% for i in {1,2,3,4,5}; time /bin/zsh -i -c exit
/bin/zsh -i -c exit  0.52s user 0.22s system 99% cpu 0.741 total
/bin/zsh -i -c exit  0.53s user 0.22s system 99% cpu 0.751 total
/bin/zsh -i -c exit  0.52s user 0.22s system 100% cpu 0.736 total
/bin/zsh -i -c exit  0.52s user 0.22s system 99% cpu 0.741 total
/bin/zsh -i -c exit  0.52s user 0.22s system 100% cpu 0.735 total

Using master branch and my custom directory.

major:~% for i in {1,2,3,4,5}; time /bin/zsh -i -c exit
/bin/zsh -i -c exit  0.53s user 0.22s system 99% cpu 0.751 total
/bin/zsh -i -c exit  0.53s user 0.22s system 100% cpu 0.752 total
/bin/zsh -i -c exit  0.52s user 0.22s system 99% cpu 0.734 total
/bin/zsh -i -c exit  0.53s user 0.22s system 99% cpu 0.756 total
/bin/zsh -i -c exit  0.53s user 0.22s system 100% cpu 0.755 total

Using this branch and no custom directory

major:~% for i in {1,2,3,4,5}; time /bin/zsh -i -c exit
/bin/zsh -i -c exit  0.52s user 0.22s system 99% cpu 0.745 total
/bin/zsh -i -c exit  0.52s user 0.22s system 99% cpu 0.742 total
/bin/zsh -i -c exit  0.52s user 0.22s system 99% cpu 0.746 total
/bin/zsh -i -c exit  0.52s user 0.22s system 100% cpu 0.735 total
/bin/zsh -i -c exit  0.52s user 0.22s system 99% cpu 0.732 total

Using master branch and no custom directory

major:~% for i in {1,2,3,4,5}; time /bin/zsh -i -c exit
/bin/zsh -i -c exit  0.54s user 0.23s system 100% cpu 0.768 total
/bin/zsh -i -c exit  0.54s user 0.22s system 99% cpu 0.761 total
/bin/zsh -i -c exit  0.52s user 0.22s system 99% cpu 0.732 total
/bin/zsh -i -c exit  0.53s user 0.22s system 99% cpu 0.749 total
/bin/zsh -i -c exit  0.53s user 0.22s system 99% cpu 0.753 total

[robbyrussell]

You're welcome.

Sincerely,
Dictator

[wrboyce]

Haha, I promise I'd been meaning to thank you for merging this!

Thanks man, and a Merry Christmas to you!

Sent from my iPhone

On 22 Dec 2014, at 23:04, Robby Russell notifications@github.com wrote:

You're welcome.

Sincerely,
Dictator

—
Reply to this email directly or view it on GitHub
#3344 (comment).