Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RDY] Remove (outdated) compdefs for git branch and git remote #3374

Closed
wants to merge 1 commit into from

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Dec 4, 2014

I was wondering why the completion for git branch was outdated (it
knows about --set-upstream only, and not -u etc), and found these
files.

I have not compared them to Zsh's upstream version, but in case there
are any additional features/fixes, they should get forwarded to them.

@stibbons
Any objections? - asking you, since you've added them.

I was wondering why the completion for `git branch` was outdated (it
knows about `--set-upstream` only, and not `-u` etc), and found these
files.

I have not compared them to Zsh's upstream version, but in case there
are any additional features/fixes, they should get forwarded to them.
@gsemet
Copy link
Contributor

gsemet commented Dec 4, 2014

I ve added them because they didn't worked well, so I ve generated them here. No idea if they are still needed...
As long as git branch and remote completion work, you can remove them

@gsemet
Copy link
Contributor

gsemet commented Dec 4, 2014

(I remember: the zsh completion on my Ubuntu was against an older git, so some sub commands were missing. I be added them here but I don't know where else to put. Should be bundled with each version of git...)

@blueyed
Copy link
Contributor Author

blueyed commented Dec 4, 2014

I see.

It normally depends on the version of Zsh you're using, that's where the compdefs get shipped with.

Normally the zsh and git versions of a distribution should be on the same level, and on an old system you do not want/need completion for new features.
But when you're using a current version of Zsh, you want the current completion it can provide, of course.

Have you copied them from somewhere?

Anyway, we agree then that they should get removed.

@gsemet
Copy link
Contributor

gsemet commented Dec 4, 2014

actually, I have extracted them from /usr/share/zsh/functions/Completion/Unix/_git that was not used I don't know why

@blueyed
Copy link
Contributor Author

blueyed commented Dec 4, 2014

That's odd then.
Are you sure? That would have meant that completion for git altogether would not have worked then?!

I am marking this PR as [RDY] (ready), and hopefully some committer will pick it up shortly.

@blueyed blueyed changed the title Remove compdefs for git branch and git remote [RDY] Remove compdefs for git branch and git remote Dec 4, 2014
@blueyed blueyed changed the title [RDY] Remove compdefs for git branch and git remote [RDY] Remove (outdated) compdefs for git branch and git remote Dec 4, 2014
@ncanceill ncanceill mentioned this pull request Apr 30, 2015
5 tasks
@ncanceill
Copy link
Contributor

Sorry it has been five months, no idea how I missed this one. Thanks again @blueyed.

@blueyed
Copy link
Contributor Author

blueyed commented May 1, 2015

It won't be closed by your commit message from there?
If so, please close it as a duplicate.

@blueyed blueyed deleted the git-remove-compdefs branch June 6, 2015 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants