Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to blacklist themes from random selector. #3703

Closed
wants to merge 1 commit into from

Conversation

FranGM
Copy link
Contributor

@FranGM FranGM commented Mar 19, 2015

If user adds themes they don't want to see to ZSH_BLACKLISTED_THEMES they won't be picked by the random theme selector.

Fixes #3704

@apjanke
Copy link
Contributor

apjanke commented Mar 20, 2015

If you put the phrase "Fixes #3704" in the main summary of this Pull Request, then it'll set up an auto-close reference to the issue so it's automatically closed when this PR is merged.

@FranGM
Copy link
Contributor Author

FranGM commented Mar 20, 2015

Fair point, thanks!

@r3cgm
Copy link

r3cgm commented Apr 28, 2017

+1 really want this feature. Hope the branch conflicts can be resolved soon.

@ttimasdf
Copy link

Is this PR still alive?

@FranGM
Copy link
Contributor Author

FranGM commented Mar 19, 2019

Hi,
My understanding is that this has been superseded by #3743 but that PR also hasn't seen activity in a while.

Not sure how much interest there is in merging this PR now that ZSH_THEME_RANDOM_CANDIDATES offers a whitelist for themes. If there's still interest we could rework this PR to complement the already existing whitelisting.

@mcornella mcornella added Area: init Issue or PR related to the initializer Status: conflicts Pull Request that has conflicts with the master branch labels Mar 24, 2019
@liyishuai
Copy link

Not sure how much interest there is in merging this PR now that ZSH_THEME_RANDOM_CANDIDATES offers a whitelist for themes. If there's still interest we could rework this PR to complement the already existing whitelisting.

Given the whitelist, I am still interested in this blacklist feature: I am willing to try new themes, except for the few ones that are annoying.

@SeanChao
Copy link

SeanChao commented Nov 10, 2019

Is this PR still active? This is a great featrue ✨👍
It worked fine in my machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: init Issue or PR related to the initializer Status: conflicts Pull Request that has conflicts with the master branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Allow user to blacklist themes from being picked by the random selector
7 participants