Rbenv directory search order with brew

[mmorga]

The bug is that as-written, rbenv (if installed by brew) always uses the brew prefix directory and the RBENV_ROOT. But the default desired behavior of rbenv is to use the $HOME/.rbenv to store installed rubies. As a result, you get the system ruby only.

My change builds upon the #3275 pull request from @mbologna and reverses the order of the search directories for rbenv to put the brew prefix last.

Since this bug only occurs for brew users, non-OSX users will not be affected.

[ncanceill]

Hi, and thanks for contributing.

You will have to git rebase -i @~2 in order to get rid of the empty merge commit.

Then please find a few people to test and +1 this.

[gchan]

+1

I haven't tested this but I have encountered the same problem on OSX and brew installed rbenv. Traced the issue with the brew directory taking priority over the $HOME directories for rubies.

[mbologna]

Is the bug still present? @mmorga @mcornella

[mcornella]

I have no idea... @gchan ?

[gchan]

Yes. I just enabled the rbenv plugin and this still happens.

[mbologna]

Probably this is why I opened #3275

[gchan]

Yes @mbologna, the code changes in #3275 are very similar to this PR.

Unsure about the reason for line 12 (https://github.com/robbyrussell/oh-my-zsh/pull/3808/files#diff-22fdd1fcfb5b98380f344442393e1f6fL12) however.

[mbologna]

@gchan @mcornella @mmorga please check with #4384 if it solves your problem

[caesarsol]

@mbologna I don't think #4384 would fix for me, since I have no bin directory in ~/.rbenv/.

I'm getting a bit lost between these PRs...
my edit would just be like the one in your #3275, specifically this line.

[mbologna]

@caesarsol #4384 does not infer anything from ~/.rbenv/bin. Please check the diff.

[caesarsol]

I'm sorry, isn't the diff only deleting lines 7~10?
I still see $rbenvdir/bin in the file...

[mbologna]

Nope. See https://github.com/mbologna/oh-my-zsh/commit/f3e357d71253a8255f1a1ccece9426f37da47d00#diff-22fdd1fcfb5b98380f344442393e1f6fL7

[caesarsol]

@mbologna sorry for the misunderstanding, what I'm saying is:
this PR doesn't solve the issue for me.
I didn't realize you were splitting two different issues.

[mbologna]

@caesarsol this PR is another PR. I did not write it.

[eugenesvk]

Thank for the fix!
Although in my case I had to make both changes (one by @caesarsol and the other one by @mbologna) to make it work. Whenever I revert to implementing only one of the changes, it all breaks down again.