Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtualenvwrapper logic improved #4178

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

virtualenvwrapper logic improved #4178

wants to merge 1 commit into from

Conversation

KenMercusLai
Copy link

  1. set ENV_NAME to current folder name instead of an empty string when .venv file is not found
  2. optimized activate & deactivated logic

…n .venv file is not found

2. optimized activate & deactivated logic
@apjanke
Copy link
Contributor

apjanke commented Jul 22, 2015

This seems like a substantial change to the existing behavior of virtualenvwrapper, which treats only git repo roots or .venv-customized dirs as project roots.

Conflicts with PR #4122, which fixes a regression related to treating git repo roots as project roots. Could you have a look at that discussion and comment there? At a minimum, this will probably need to be rebased after #4122 is merged. And the change in behavior should probably be put up for discussion with other virtualenvwrapper users.

@apjanke
Copy link
Contributor

apjanke commented Nov 6, 2015

Now that #4122 is merged, can you review to see if this is still needed, and if so, rebase it against the latest master? This will probably require some manual changes even if it is a clean rebase, since #4122 included a change to the search logic.

@mcornella mcornella added Area: plugin Issue or PR related to a plugin Status: conflicts Pull Request that has conflicts with the master branch labels Mar 24, 2019
@mcornella mcornella removed the Status: conflicts Pull Request that has conflicts with the master branch label May 27, 2019
@mcornella mcornella added the Status: conflicts Pull Request that has conflicts with the master branch label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: plugin Issue or PR related to a plugin Status: conflicts Pull Request that has conflicts with the master branch
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

None yet

3 participants