Honor ZSH_TMUX_ITERM2 for new-session and attach #4422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -60,8 +60,12 @@ if which tmux &> /dev/null | |||
| # Wrapper function for tmux. | |||
| function _zsh_tmux_plugin_run() | |||
| { | |||
| # We attach to existing or start new session | |||
| if [[ -n "${@[(r)attach]}" || -n "${@[(r)new-session]}" ]] | |||
There was a problem hiding this comment.
Might also want to check for the attach-session and new command aliases.
Should this be picking up the "ZSH_TMUX_FIXTERM stuff too, so it matches the attach/new-session behavior of the other branches?
There was a problem hiding this comment.
It's possible to make this into a one conditional with |:
if [[ -n "${@[(r)attach|attach-session|new|new-session]}" ]]
|
Yes, this is a bug for all tmux command alias such as |
mcornella
added
Area: plugin
|
@shaxbee Can you please rebase this PR onto our latest master branch. Then update this PR with a Commit please? Thank You! |
|
Any updates on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option ZSH_TMUX_ITERM2 is not taking effect when attaching to or creating new session.
The fix is to scan arguments passed to tmux for new-session and attach and inject '-CC' option when eligible.