Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid "ls -G" alias. #4988

Closed
wants to merge 2 commits into from
Closed

Fix invalid "ls -G" alias. #4988

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c71b22
Fix invalid "ls -G" alias.
reduardo7 Apr 10, 2016
46380a3
Merge branch 'master' into patch-1
reduardo7 Oct 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/theme-and-appearance.zsh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ if [[ "$DISABLE_LS_COLORS" != "true" ]]; then
(( $+commands[dircolors] )) && eval "$(dircolors -b)"
fi

ls --color -d . &>/dev/null && alias ls='ls --color=tty' || alias ls='ls -G'
ls --color -d . &>/dev/null && alias ls='ls --color=tty' || ls -G . &>/dev/null && alias ls='ls -G'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be:

ls --color -d . &>/dev/null && alias ls='ls --color=tty' || (ls -G . &>/dev/null && alias ls='ls -G')

Note the parenthesis around the second test. This should fix the various ls colors issue that people are seeing.


# Take advantage of $LS_COLORS for completion as well.
zstyle ':completion:*' list-colors "${(s.:.)LS_COLORS}"
Expand Down