Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

installer: git clone using ssh URL if https fails #5194

Closed
wants to merge 2 commits into from
Closed

installer: git clone using ssh URL if https fails #5194

wants to merge 2 commits into from

Conversation

pierrickrouxel
Copy link

I added IBM i support. Just few changes.

@dabou
Copy link

dabou commented Jun 30, 2016

oh yes, oh-my-zsh on IBM i !
Thank's 🎉

apjanke
apjanke reviewed Jul 13, 2016
View reviewed changes
lib/theme-and-appearance.zsh
@@ -17,6 +17,8 @@ then
# coreutils, so prefer it to "gls".
gls --color -d . &>/dev/null 2>&1 && alias ls='gls --color=tty'
colorls -G -d . &>/dev/null 2>&1 && alias ls='colorls -G'
elif [[ "$(uname -s)" == "OS400" ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be done with a generic test of whether ls -G is supported, instead of adding an OS-specific test?

@pierrickrouxel
Copy link
Author

Ok I will do that.

@apjanke
Copy link
Contributor

apjanke commented Jul 13, 2016

See also #4988, which looks like it's attempting the same thing.

@pierrickrouxel
Copy link
Author

I removed changes on ls appearance. The #4988 solves the problem more efficiently.

@mcornella mcornella added Area: core Issue or PR related to core parts of the project Area: installer Issue or PR related to the installer Status: conflicts Pull Request that has conflicts with the master branch labels Mar 24, 2019
@mcornella mcornella changed the title Add IBM i support installer: git clone using ssh URL if https fails May 24, 2019
@mcornella mcornella mentioned this pull request May 24, 2019
Closed
36 tasks
@mcornella
Copy link
Member

The HTTPS-to-SSH remote URL change won't be needed now that #5169 introduces the ability to change the remote URL via the REMOTE variable (so you could run REMOTE=git@github.com:robbyrussell/oh-my-zsh.git sh install.sh, for example). This PR will be automatically closed when #5169 is merged.

@mcornella
Copy link
Member

As I said above, #5169 adds the ability to configure the remote URL, so you can now use an SSH remote.

If you want to help speed up the testing and merge (which should happen early next week), you can wget or curl it from the URL https://raw.githubusercontent.com/mcornella/oh-my-zsh/refactor-installer/tools/install.sh. Read the comments at the top of the script to know how to call it.

Thanks!

@mcornella
Copy link
Member

Closed by #5169.

@mcornella mcornella closed this Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: core Issue or PR related to core parts of the project Area: installer Issue or PR related to the installer Status: conflicts Pull Request that has conflicts with the master branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pierrickrouxel @dabou @apjanke @mcornella