Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow completion of dot directories #6803

Merged
merged 1 commit into from
May 7, 2018

Conversation

mcornella
Copy link
Member

Fixes #3775, fixes #6543.

This makes zsh treat . and .. as directories to be completed. That means it will insert a slash (/) when these directories are provided in the command line.

@mcornella mcornella merged commit 6bff079 into ohmyzsh:master May 7, 2018
@mcornella mcornella deleted the complete-dot-directories branch May 7, 2018 16:15
gerardo pushed a commit to gerardo/oh-my-zsh that referenced this pull request May 8, 2018
…' of https://github.com/robbyrussell/oh-my-zsh

* 'master' of github.com:gerardo/oh-my-zsh:

* 'master' of https://github.com/robbyrussell/oh-my-zsh: (87 commits)
  Removed duplicate fedora from plugins, dnf provides exact same features
  Fix branch not updating on checkout in steeef (ohmyzsh#6784)
  Allow completion of dot directories (ohmyzsh#6803)
  Add READMEs to plugins copydir and copyfile (ohmyzsh#6802)
  fix bug for check zsh (ohmyzsh#6798)
  installer: check if zsh in path instead of /etc/shells
  Correctly handle verbose/version flags for rustc (ohmyzsh#6786)
  Parse branch-name for fresh repo (ohmyzsh#6302)
  Add aliases for kubectl ingress (ohmyzsh#6762)
  Revert to checking if `enable-ssh-support` is set
  Added ecto tasks (ohmyzsh#6035)
  Fix mix-fast plugin (ohmyzsh#6708)
  Remove unneeded option in glol and glola (ohmyzsh#6059)
  Better app error handling in curl (ohmyzsh#5828)
  Check for Microsoft's WSL in open_command (ohmyzsh#6751)
  Simplify hub check and hardcode aliasing (ohmyzsh#6767)
  [half-life] Fix last command check
  $ rails runner [TAB] *complete* (ohmyzsh#5881)
  [subl] Fix local variable definition
  Make steeef theme much faster by not iterating through all history (ohmyzsh#6359)
  ...
@asqui
Copy link

asqui commented May 29, 2018

Should this be off by default, since it's a change in completion behaviour?

(I was certainly surprised about the change and had to go digging to find that this was the cause.)

@mcornella
Copy link
Member Author

There were users surprised by the lack of this feature, and enabling it just means you have to type a letter after the dot to complete to hidden files, which I presume is your use case.

aunsira pushed a commit to aunsira/oh-my-zsh that referenced this pull request Jun 13, 2018
gsemet pushed a commit to gsemet/oh-my-zsh that referenced this pull request Jun 15, 2018
seth-cohen pushed a commit to seth-cohen/oh-my-zsh that referenced this pull request Oct 29, 2018
jmartindf pushed a commit to jmartindf/oh-my-zsh that referenced this pull request Nov 10, 2018
sagischwarz pushed a commit to sagischwarz/ohmyzsh that referenced this pull request Nov 19, 2018
chihchun pushed a commit to chihchun/oh-my-zsh that referenced this pull request Aug 6, 2019
banzera added a commit to banzera/oh-my-zsh that referenced this pull request Oct 30, 2019
* upstream/master: (146 commits)
  last-working-dir: disable chpwd_last_working_dir in subshells (ohmyzsh#6817)
  Update AWS completion (ohmyzsh#6745)
  Add autocomplete plugin for minikube (ohmyzsh#6436)
  gradle plugin should support kotlin gradle build files (ohmyzsh#6529)
  Removed duplicate fedora from plugins, dnf provides exact same features
  Fix branch not updating on checkout in steeef (ohmyzsh#6784)
  Allow completion of dot directories (ohmyzsh#6803)
  Add READMEs to plugins copydir and copyfile (ohmyzsh#6802)
  fix bug for check zsh (ohmyzsh#6798)
  installer: check if zsh in path instead of /etc/shells
  Correctly handle verbose/version flags for rustc (ohmyzsh#6786)
  Parse branch-name for fresh repo (ohmyzsh#6302)
  Add aliases for kubectl ingress (ohmyzsh#6762)
  Revert to checking if `enable-ssh-support` is set
  Added ecto tasks (ohmyzsh#6035)
  Fix mix-fast plugin (ohmyzsh#6708)
  Remove unneeded option in glol and glola (ohmyzsh#6059)
  Better app error handling in curl (ohmyzsh#5828)
  Check for Microsoft's WSL in open_command (ohmyzsh#6751)
  Simplify hub check and hardcode aliasing (ohmyzsh#6767)
  ...
kankongmeng pushed a commit to kankongmeng/oh-my-zsh that referenced this pull request Jan 8, 2020
spiliopoulos pushed a commit to spiliopoulos/zsh-config that referenced this pull request Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cd .. completion not working Insert slash (/) as a result of tab-completion after two dots (..)
2 participants