Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fzf plugin #6910

Merged
merged 1 commit into from
Sep 4, 2018
Merged

Add fzf plugin #6910

merged 1 commit into from
Sep 4, 2018

Conversation

maxbrunet
Copy link
Contributor

Add junegunn's fzf fuzzy auto-completion and key bindings

  • Try to find fzf installation directory in official and suggested locations
    (Homebrew, Git, Arch Linux, Fedora)
  • Add bin directory to PATH, enable auto-completion and key bindings
    (extracted from the official install script)
  • Support for disabling auto-completion or/and key bindings

Closes #3003

@maxbrunet maxbrunet mentioned this pull request Jun 12, 2018
Closed
@briantully
Copy link

Any update on this? Currently it seems fzw keybindings are incompatible with ohmyzsh, so this plugin would be a huge win.

@mcornella mcornella merged commit 86542dc into ohmyzsh:master Sep 4, 2018
@mcornella
Copy link
Member

Thanks @maxbrunet!

@DL-85 DL-85 mentioned this pull request Sep 5, 2018
Closed
@lalo
Copy link

lalo commented Sep 5, 2018 •
edited

Is this working? I did a quick test and it seems that the key bindings don't last. If I manually add the source "$fzf_base/shell/key-bindings.zsh" at the end of my .zshrc it will work. Can somebody repro?

Update: I think it is related to me using the vi-mode plugin too which could make the bindkeys go away perhaps?

@maxbrunet just in case it does not ping you since its closed

doubleloop
doubleloop reviewed Sep 6, 2018
View reviewed changes
plugins/fzf/README.md

plugins=(
...
fzf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: if fzf plugin is placed before vi-mode plugin, ctrl-r shortcut will not work by default

lesterchan added a commit to lesterchan/oh-my-zsh that referenced this pull request Sep 7, 2018
@lesterchan
Merge remote-tracking branch 'upstream/master'
122c6f4 
* upstream/master: (225 commits)
  Feat: add Salt completion plugin (ohmyzsh#7031)
  Add fzf plugin (ohmyzsh#6910)
  fasd: use xdg-open in o alias back again
  fasd: drop-in replace the autojump j alias (ohmyzsh#3860)
  jump: fix printf path output (ohmyzsh#7105)
  vi-mode: reset-prompt if zle is active (TRAPWINCH)
  fix nmap vuln category name (ohmyzsh#7044)
  Update kubectl.plugin.zsh (ohmyzsh#6636)
  Fix rvm-prompt usage in fino* themes (ohmyzsh#6477)
  vi-mode show indicator on zle-line-init and SIGWINCH (ohmyzsh#6449)
  execute mvnw with "mvn" when mvnw-file is present (ohmyzsh#6484)
  executing gradlew, when gradlew-file exists (ohmyzsh#6485)
  Fixed `fwl` function in `firewalld` plugin when `sources` used (ohmyzsh#7011)
  kubectl: add alias for `kubectl cp` (ohmyzsh#7068)
  Update golang.plugin.zsh (ohmyzsh#6750)
  Update brew.plugin.zsh (ohmyzsh#6947)
  Add aliases for kubectl nodes (ohmyzsh#7093)
  Clarify random theme setting (ohmyzsh#7090)
  [plugins/git] Updated git clone alias (ohmyzsh#6893)
  Updating 'sbcl' to 'sbcln' (ohmyzsh#7095)
  ...
@captainju
Copy link

Arch user here, I installed the default fzf package https://www.archlinux.org/packages/community/x86_64/fzf/

There is an error when loading the plugin:
/usr/share/oh-my-zsh//plugins/fzf/fzf.plugin.zsh:source:42: no such file or directory: /usr/share/fzf/shell/key-bindings.zsh

Indeed, the file key-bindings.zsh is located in /usr/share/fzf/
Should we add this path into the plugin, or modify the arch package to include the shell folder?

@maxbrunet
Copy link
Contributor Author

Hey @captainju, this is a known issue #7110, we are working on it, feel free to comment there.

lellisls pushed a commit to lellisls/oh-my-zsh that referenced this pull request Oct 1, 2018
@maxbrunet @lellisls
Add fzf plugin (ohmyzsh#6910)
d9bb702
seth-cohen pushed a commit to seth-cohen/oh-my-zsh that referenced this pull request Oct 29, 2018
@maxbrunet
Add fzf plugin (ohmyzsh#6910)
3e54710
jmartindf pushed a commit to jmartindf/oh-my-zsh that referenced this pull request Nov 10, 2018
@maxbrunet @jmartindf
Add fzf plugin (ohmyzsh#6910)
3380c8c
sagischwarz pushed a commit to sagischwarz/ohmyzsh that referenced this pull request Nov 19, 2018
@maxbrunet @mcornella
Add fzf plugin (ohmyzsh#6910)
a28dc82
stonetao pushed a commit to stonetao/oh-my-zsh that referenced this pull request Apr 7, 2019
@maxbrunet @stonetao
Add fzf plugin (ohmyzsh#6910)
53a2e73
chihchun pushed a commit to chihchun/oh-my-zsh that referenced this pull request Aug 6, 2019
@maxbrunet @chihchun
Add fzf plugin (ohmyzsh#6910)
d9fc8f7
lewg pushed a commit to lewg/oh-my-zsh that referenced this pull request Nov 25, 2019
@maxbrunet @lewg
Add fzf plugin (ohmyzsh#6910)
139c955
kankongmeng pushed a commit to kankongmeng/oh-my-zsh that referenced this pull request Jan 8, 2020
@maxbrunet
Add fzf plugin (ohmyzsh#6910)
3f045d4
spiliopoulos pushed a commit to spiliopoulos/zsh-config that referenced this pull request Jun 17, 2020
@maxbrunet @spiliopoulos
Add fzf plugin (ohmyzsh#6910)
e387960
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doubleloop doubleloop doubleloop left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@maxbrunet @briantully @mcornella @lalo @captainju @doubleloop