Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make installation script configurable for forks #7496

Closed
wants to merge 1 commit into from
Closed

make installation script configurable for forks #7496

wants to merge 1 commit into from

Conversation

ayandyl
Copy link

@ayandyl ayandyl commented Jan 6, 2019

This branch replaces the hardcoded robbyrussell repo owner with a configurable variable in the install.sh script, so that fork maintainers (or private forks) can replace it with their namespace, and install the forked version of oh-my-zsh pointing at their fork.

This preserves original behavior by defaulting the said variable to robbyrussell.

@mcornella mcornella added Area: core Issue or PR related to core parts of the project Area: installer Issue or PR related to the installer labels Mar 24, 2019
@mcornella
Copy link
Member

mcornella commented May 24, 2019

Will be fixed by #3648.

@ayandyl
Copy link
Author

ayandyl commented May 24, 2019

noted thanks @mcornella

@mcornella
Copy link
Member

#5169 now pulls in the ability to install from forked by setting these variables:

The installer respects the following environment variables, that can be set up when calling it with VAR=value sh install.sh.

  • REPO: value in the form of owner/project. Useful for forks in GitHub (defaults to `robbyrussell/oh-my-zsh).
  • BRANCH: default branch to check out once the clone has finished (defaults to master).
  • REMOTE: full remote URL (supersedes REPO if set). You could for example choose an ssh remote URL, like git@github.com:user/oh-my-zsh, or another fork from GitLab or Bitbucket.

If you want to help speed up the testing and merge (which should happen early next week), you can wget or curl it from the URL https://raw.githubusercontent.com/mcornella/oh-my-zsh/refactor-installer/tools/install.sh. Read the comments at the top of the script to know how to call it.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: core Issue or PR related to core parts of the project Area: installer Issue or PR related to the installer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants