Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement to issue number #7332 #7656

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Improvement to issue number #7332 #7656

wants to merge 4 commits into from

Conversation

chuckstar76
Copy link

Improvement to issue number #7332
updated my oh-my-zsh.sh file - because of the same reason "it looks like this is because regardless of the set $ZSH directory the ZSH_COMPDUMP file is always set to point to the $HOME directory."

# Save the location of the current completion dump file.
if [ -z "$ZSH_COMPDUMP" ]; then
  ZSH_COMPDUMP="${ZDOTDIR:-${ZSH}}/cache/.zcompdump-${SHORT_HOST}-${ZSH_VERSION}"
fi

Replacing ${HOME}} with ${ZSH}}/cache
I think this is a much more tidy way of doing things.

Improvement to issue number  #7332
updated my oh-my-zsh.sh file - because of the same reason "it looks like this is because regardless of the set $ZSH directory the ZSH_COMPDUMP file is always set to point to the $HOME directory."

# Save the location of the current completion dump file.
if [ -z "$ZSH_COMPDUMP" ]; then
  ZSH_COMPDUMP="${ZDOTDIR:-${ZSH}}/cache/.zcompdump-${SHORT_HOST}-${ZSH_VERSION}"
fi
Replacing ${HOME}} with ${ZSH}}/cache
I think this is much more tidy way of doing things.
@mcornella mcornella added the Area: init Issue or PR related to the initializer label Mar 24, 2019
…not found"

As MacOS users may have ZSH plugins installed via Homebrew the normal oh-my-zsh will not search the brew plugin directory
added search and fpath update for:
````
/usr/local/Cellar/$plugin
````
Improvement to issue number #7688 & #7686 for MacOS -"plugin not found"
@chuckstar76
Copy link
Author

chuckstar76 commented Mar 25, 2019

@mcornella - after reading through #7690 in more detail that last PR can be ignored...
Best solved by removing no $ZSH/plugins sourced plugins from that part of the .zshrc

@mcornella mcornella added the Status: conflicts Pull Request that has conflicts with the master branch label Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: init Issue or PR related to the initializer Status: conflicts Pull Request that has conflicts with the master branch
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

None yet

2 participants