Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace %{$fg[color]%} by %F{color} in themes #8487

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ericbn
Copy link

@ericbn ericbn commented Dec 19, 2019

that only change the foreground color. %F works at least since Zsh 4.3.

@ohmyzsh ohmyzsh bot added the Area: theme Issue or PR related to a theme label Dec 19, 2019
@ericbn
Copy link
Author

ericbn commented Dec 19, 2019

These prompt sequences work since Zsh 4.3. At last since Zsh 4.3.11, released in 2010!

Screen Shot 2019-12-18 at 19 48 47

@mcornella mcornella added the Status: conflicts Pull Request that has conflicts with the master branch label Mar 4, 2020
that only change the foreground color. %F works at least since Zsh 4.3.
@ohmyzsh ohmyzsh bot removed the Status: conflicts Pull Request that has conflicts with the master branch label Jun 15, 2020
@awasum
Copy link

awasum commented Jun 18, 2020

Looking good... Thanks @ericbn

@mcornella mcornella added the Status: blocked Issue or pull request that depends on another label Apr 6, 2022
@mcornella mcornella marked this pull request as draft April 6, 2022 20:13
@mcornella
Copy link
Member

Needs automated theme testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: theme Issue or PR related to a theme Status: blocked Issue or pull request that depends on another
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

None yet

3 participants