Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Symfony Console Selection Priority #8523

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Symfony Console Selection Priority #8523

wants to merge 1 commit into from

Conversation

huebs
Copy link

@huebs huebs commented Jan 6, 2020

This change selects the last (instead of the first) console executable found. This has the effect of selecting bin/console instead of app/console when both exist. The app/console executable has been deprecated and displays a warning when it's called. Without this change, using any of the plugin's aliases will also cause the warning to display.

@ohmyzsh ohmyzsh bot added the Area: plugin Issue or PR related to a plugin label Jan 6, 2020
bartekpacia
bartekpacia approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@bartekpacia bartekpacia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartekpacia bartekpacia bartekpacia approved these changes

@kbakdev kbakdev kbakdev approved these changes

Assignees
No one assigned
Labels
Area: plugin Issue or PR related to a plugin
Projects
Main project
Status: Backlog
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@huebs @bartekpacia @kbakdev