Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Master palette export produces a semi-broken BMP file #1070

Closed
ohrrpgce-bugbot opened this issue May 18, 2015 · 3 comments
Closed

Master palette export produces a semi-broken BMP file #1070

ohrrpgce-bugbot opened this issue May 18, 2015 · 3 comments
Labels
bug Yeah... that's broken graphics

Comments

@ohrrpgce-bugbot
Copy link

[sf#2011]

Exporting a master palette from a game produces a bmp file that is partially broken.

In my test, the file can be previewed by my file manager, and opened in the Gnome Image Previewer, but when I try to opne it with The Gimp, or convert it with ImageMagick, it fails.

"Opening '/home/james/src/ohr/games/vorpalflorist/masterpal.bmp' failed:

'/home/james/src/ohr/games/vorpalflorist/masterpal.bmp' is not a valid BMP file"

james@⁠cactusgolem:~/src/ohr/games/vorpalflorist$ convert masterpal.bmp masterpal.png
convert.im6: insufficient image data in file masterpal.bmp' @⁠ error/bmp.c/ReadBMPImage/887. convert.im6: no images defined masterpal.png' @⁠ error/convert.c/ConvertImageCommand/3044.

From: @bob-the-hamster
Reported version: Nightly WIP (Callipygous)
Operating system: Linux
@ohrrpgce-bugbot ohrrpgce-bugbot added the bug Yeah... that's broken label Mar 14, 2020
@rversteegen
Copy link
Contributor

Oh, whoops, this is the same as bug #1143: the same error is produced by ImageMagick.

@rversteegen rversteegen added graphics resolved: duplicate A duplicate of another bug labels Aug 9, 2020
@rversteegen rversteegen mentioned this issue Aug 9, 2020
Closed
@rversteegen
Copy link
Contributor

My mistake, this is not a dup of #1143, although it does cause a similar error message.

@rversteegen rversteegen reopened this Aug 22, 2020
@rversteegen rversteegen removed the resolved: duplicate A duplicate of another bug label Aug 22, 2020
rversteegen added a commit that referenced this issue Aug 22, 2020
@rversteegen
Fix bug #1070 Master palette export produces a semi-broken BMP file
c546ad8 
We were writing 24- BMPs with number of palette colours set to 2^24 in the
header, which some programs understandably didn't like.

git-svn-id: https://rpg.hamsterrepublic.com/source/wip@11963 7d344553-34f0-0310-a9b1-970ce8f1c3a2
@rversteegen
Copy link
Contributor

Odd, why didn't github autoclose this due to me writing "Fix bug #1070" in a commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Yeah... that's broken graphics
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rversteegen @ohrrpgce-bugbot