Space and Ctrl cause Enter to appear pressed, Alt causes ESC to appear pressed

[rversteegen]

Pressing Space or Ctrl results in key is pressed(key:enter) returning true if the "Map joystick controls to keyboard keys for scripts" general pref bit is on -- and it is by default in all games since a year ago (fufluns) -- and ditto for Alt and ESC.

This is caused by this block in script_keyval (added r10966 (daaad76)):

 IF prefbit(47) = NO THEN  '!Map joystick controls to keyboard keys for scripts
  SELECT CASE key
   CASE scUp:     ret OR= keyval(ccUp)
   CASE scDown:   ret OR= keyval(ccDown)
   CASE scLeft:   ret OR= keyval(ccLeft)
   CASE scRight:  ret OR= keyval(ccRight)
   CASE scEnter:  ret OR= keyval(ccUse)
   CASE scEsc:    ret OR= keyval(ccCancel)
  END SELECT
 END IF

Unfortunately this is a bit tricky to fix without breaking this prefbit because of the way carray is now computed. I think I need to refactor that code in allmodex to give each input device its own carray array, so that we can check just the joystick carray and map that to keyboard keys.

[rversteegen]

Wow, I forgot that I already fixed this bug once before. Well now it's back! I was wondering why I left it unfixed for so long, but actually I rebroke this only recent in r12270 (ef83342).

[rversteegen]

Fixed again in r12393.