Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

One-time-use NPC tags don't consider global NPCs #1219

Closed
bob-the-hamster opened this issue Sep 26, 2021 · 1 comment
Closed

One-time-use NPC tags don't consider global NPCs #1219

bob-the-hamster opened this issue Sep 26, 2021 · 1 comment
Assignees
@bob-the-hamster
Labels
bug Yeah... that's broken map editor npcs rel: hrodvitnir Present in hróðvitnir 2021-09-13 rel: New in ... Introduced in the tagged "rel:" release/nightlies tags
Milestone
Ichorescent

Comments

@bob-the-hamster
Copy link
Collaborator

Spun off from issue #1216
one time use tags for NPCs are supposed to check for conflicts, but Global NPC definitions are not being considered, making it possible (unavoidable?) to have conflicts on one-time-use global NPCs
@bob-the-hamster bob-the-hamster added the bug Yeah... that's broken label Sep 26, 2021
@bob-the-hamster bob-the-hamster added this to the Ichorescent milestone Sep 26, 2021
@bob-the-hamster bob-the-hamster mentioned this issue Sep 26, 2021
Closed
@bob-the-hamster bob-the-hamster self-assigned this Sep 26, 2021
@bob-the-hamster
Copy link
Collaborator Author

I have pushed a fix for this.

I have not attempted to auto-fix any conflicting one-time-use IDs (just as we don't attempt to fix them for map copying)

bob-the-hamster added a commit that referenced this issue Sep 28, 2021
@bob-the-hamster
Fix #1219 Global NPCs now properly support one-time-use tags
d2686fc 
git-svn-id: https://rpg.hamsterrepublic.com/source/wip@12508 7d344553-34f0-0310-a9b1-970ce8f1c3a2
@rversteegen rversteegen added map editor npcs rel: hrodvitnir Present in hróðvitnir 2021-09-13 rel: New in ... Introduced in the tagged "rel:" release/nightlies tags labels Sep 28, 2021
bob-the-hamster pushed a commit that referenced this issue Sep 30, 2021
@rversteegen
Fix global NPC one-time-use tags possibly colliding with ones used by…
0f5a350 
… local NPCs

Happened because local NPCs weren't saved before entering global NPC editor from
the main mapedit menu

Related to/another case of #1219 One-time-use NPC tags don't consider global NPCs

git-svn-id: https://rpg.hamsterrepublic.com/source/wip@12519 7d344553-34f0-0310-a9b1-970ce8f1c3a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bob-the-hamster bob-the-hamster

Labels
bug Yeah... that's broken map editor npcs rel: hrodvitnir Present in hróðvitnir 2021-09-13 rel: New in ... Introduced in the tagged "rel:" release/nightlies tags
Projects
None yet
Milestone
Ichorescent
Development

No branches or pull requests
2 participants
@rversteegen @bob-the-hamster