fix the bug that made double callback

ohsc · Oct 23, 2012 · 620d7b5 · 620d7b5
1 parent e0a6beb
commit 620d7b5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "dnspod-client",
-  "version": "0.1.0",
+  "version": "0.1.1",
   "description": "A DNSPOD Client",
   "keywords": [
     "dnspod", "ddns", "get ip"

diff --git a/src/dnspod.js b/src/dnspod.js
@@ -56,9 +56,15 @@ Dnspod.prototype.request = function(url, params, eventListenerName){
         }).on('end', function() {
             try {
                 var jsonData = JSON.parse(resData.join(''));
-                self.emit(eventListenerName, null, jsonData);
             } catch (ex) {
-                self.emit(eventListenerName, new Error('Request failed'));
+                console.log(ex);
+                var err = ex;
+            } finally {
+                if(err) {
+                    self.emit(eventListenerName, new Error('Request failed'));
+                } else {
+                    self.emit(eventListenerName, null, jsonData);
+                }
             }
         });
     };
@@ -176,4 +182,4 @@ function mergeJSON(obj1, obj2) {
   return obj1;
 }
 
-module.exports = Dnspod;
+module.exports = Dnspod;