Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malformed URL when setting external artefact server #3

Closed
vikanezrimaya opened this issue Sep 22, 2017 · 1 comment
Closed

Malformed URL when setting external artefact server #3

vikanezrimaya opened this issue Sep 22, 2017 · 1 comment
Labels
Milestone

Comments

@vikanezrimaya
Copy link

When I set LAMINAR_ARCHVE_URL, my artefact suddenly got a strange URL: http://192.168.1.33:8080/jobs/hello/https://ci.<mydomain.tld>/archive/hello/1/hello-20170922.

I'm accessing Laminar via HTTP because I cannot proxy websockets with my lighttpd server - it lacks mod_websocket to do it, and Laminar is trying to access unsecured socket anyway - but the reason is not important as different URL schemes probably are.

@ohwgiles
Copy link
Owner

Right, that's probably a bug I introduced moving from angular to vue. I've pushed a fix so that LAMINAR_ARCHIVE_URL is linked properly in the frontend.

I've also pushed a change to the websocket access - it will directly open a secured websocket if it's running under https. Like you say, this depends on support from the reverse proxy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants