-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working and no error message #44
Comments
Same here on Mac OS, python 3.10.9, got this output for each image iteration:
|
Reference to Unable to get link #33 Try these packages and version Every second image we tried to download showed unable to get link, after updating the packages it went a bit smoother and faster. Only every 50 images or so now go into an unable to get link loop :) |
Even with the packages recommended, I'm getting the |
After doing a little experimentation, Google Images has changed how their elements are structured on results. After 50 or so images, they've inserted a "Related Searches" element, and after this, they now include an element that encompasses the next 50 images. After that, the "Related Searches" element reappears, and then another parent element holding the next 50 images appears, and so on. On top of this, they have changed the class name of the image element as well, hence why it doesn't download any longer. |
Okay so, what is the next step? Do we disable the automatic update of the chrome driver to use the latest, most stable chrome driver/version that doesn't use the "related image results" function? Or do we enable images to download from encrypted websites? Like Https? Cuz after also playing with the code and using 360 image search keys we also have 50% accurate downloads. Especially with the search keys being more than 1 word for example "Phillips coffee machine and grinder". Please let me know because this has been driving me mad for months. |
Hi, seems like the class tag used to identify the image link has changed, which resulted in this issue. I'm working on a fix now, will update everyone soon. |
Patch has been released. It has been tested only on Windows OS, and may not work on others. |
You're a life saver @ohyicong ! Thank you for your quick response time and amazing xpath skills. Let me know if there is anywhere I can go to buy you a coffee or whatever :)! |
@ohyicong our downloads are amazing now! No unable to get links, and the accuracy is amazing!!! Thank you so much, you genius! |
Thanks for your unwavering support, but I'm now facing another problem. Once I call the browser and approach Google, the 'Before you continue' pop-up window appears and won't let the remaining code run. Let me know if you know of any solution for it. |
Hi @AmirSh15, this issue was highlighted by other users before, I wanted to fix it but I can't replicate the "pop-up" behavior on my computer. If you have a solution, I don't mind merging it into my repository. I will close this thread, as this is a separate issue. Thanks! |
Hi @ohyicong, I found the solution for the cookie pop-up window once google.com is called. It seems that in the new chrome version this window appears! You only need to add the below script after this line of code.
|
Followed the readme step by step but nothing happens when I launch the script in my terminal, the folders are created and then nothing.
Env : Ubuntu 20.04.5 LTS running on WSL
The text was updated successfully, but these errors were encountered: