-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add openid-connect-generic-session-expired action on session expiry before logout #228
Add openid-connect-generic-session-expired action on session expiry before logout #228
Conversation
Add openid-connect-generic-session-expired action before to allow consumers to act on the refresh token expiration
@jkouris this PR is failing both WordPress coding standards. You can run these check with NPM if you have the local development environment setup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jkouris I'd like to include this in the next release that I want to push out soon. Can you update this to resolve the Coding Standards issues. You can find the issues here: https://github.com/oidc-wp/openid-connect-generic/runs/5338133715?check_suite_focus=true Thanks!
@timnolte I have resolved the coding standards issues and verified it passes when running locally |
Add openid-connect-generic-session-expired action before to allow consumers to act on the refresh token expiration
All Submissions:
Changes proposed in this Pull Request:
Added action 'openid-connect-generic-session-expired' to allow client to react to the session expiry (refresh token expired) just before logging the user out and redirecting them back to the login page. It can be useful in situations where SSO is being used across multiple apps. In this case the user is logged in with the SSO provider via another app, but has timed out of wordpress. This allows a hook to re-authenticate them automatically and allow access to the resource based. The action provides the user and the REDIRECT_URI as parameters to allow any necessary action to be taken on timeout with the url and parameters provided.
Closes # .
How to test the changes in this Pull Request:
add_action('openid-connect-generic-session-expired', 'expired_method', 10, 2);
Other information:
Changelog entry