Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregated claims #255

Merged
merged 11 commits into from
Feb 25, 2022
Merged

Aggregated claims #255

merged 11 commits into from
Feb 25, 2022

Conversation

schanzen
Copy link
Contributor

@schanzen schanzen commented Jan 5, 2021

All Submissions:

Changes proposed in this Pull Request:

This pull request should fix #254. However, it does not fully implement the spec.

How to test the changes in this Pull Request:

  1. Get (most) claims inside a JWT from "_claim_sources" referenced by "_claim_names"
  2. See that the user gets correctly added to the DB

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changelog entry

Support OIDC Aggregated Claims.

@timnolte timnolte self-assigned this Jan 12, 2021
@timnolte timnolte added enhancement Issues & PRs related to new features. status: needs review PR that needs review. labels Jan 12, 2021
@timnolte
Copy link
Collaborator

@schanzen FYI, this PR is failing due to coding standards and static analysis failures. Please address these and then I'll take another look at this PR. Thanks!

@schanzen
Copy link
Contributor Author

@schanzen FYI, this PR is failing due to coding standards and static analysis failures. Please address these and then I'll take another look at this PR. Thanks!

Ok fixed!

@timnolte timnolte added this to the 3.9.0 milestone Jan 22, 2021
@timnolte timnolte added this to To do in 3.9.0 Release Jan 30, 2021
@timnolte timnolte moved this from To do to In progress in 3.9.0 Release Jan 30, 2021
@timnolte timnolte merged commit 6baee18 into oidc-wp:dev Feb 25, 2022
@timnolte timnolte added status: approved PRs that have been approved and ready to be merged. and removed status: needs review PR that needs review. labels Feb 25, 2022
@timnolte timnolte moved this from In progress to Done in 3.9.0 Release Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues & PRs related to new features. status: approved PRs that have been approved and ready to be merged.
Projects
No open projects
3.9.0 Release
  
Done
Development

Successfully merging this pull request may close these issues.

Plugin fails with incomplete-user-claim when email is in attested claims
2 participants