Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactors new ACR Handling Code for Better Code Quality #389

Merged
merged 1 commit into from Mar 9, 2022
Merged

Refactors new ACR Handling Code for Better Code Quality #389

merged 1 commit into from Mar 9, 2022

Conversation

timnolte
Copy link
Collaborator

@timnolte timnolte commented Mar 9, 2022

All Submissions:

Changes proposed in this Pull Request:

Closes #331.

  • Fixes some incorrect ACR handling code that incorrectly added the ACR when it wasn't set.
  • Adds missing settings disable handling when ACR constant is set.
  • Refactors code for simplicity and code quality.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

@timnolte
Refactors new ACR Handling Code for Better Code Quality
63ef4bb 
* Fixes some incorrect ACR handling code that incorrectly
  added the ACR when it wasn't set.
* Adds missing settings disable handling when ACR constant
  is set.
* Refactors code for simplicity and code quality.
@timnolte timnolte mentioned this pull request Mar 9, 2022
Merged
6 tasks
@timnolte timnolte self-assigned this Mar 9, 2022
@timnolte timnolte added the status: approved PRs that have been approved and ready to be merged. label Mar 9, 2022
@timnolte timnolte added this to To do in 3.9.0 Release via automation Mar 9, 2022
@timnolte timnolte added this to the 3.9.0 milestone Mar 9, 2022
@timnolte timnolte merged commit 1fb512f into oidc-wp:dev Mar 9, 2022
3.9.0 Release automation moved this from To do to Done Mar 9, 2022
@timnolte timnolte deleted the refactor/331-acr-values branch March 9, 2022 04:23
@timnolte timnolte mentioned this pull request Apr 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daggerhart daggerhart Awaiting requested review from daggerhart daggerhart is a code owner

Assignees

@timnolte timnolte

Labels
status: approved PRs that have been approved and ready to be merged.
Projects
No open projects
3.9.0 Release
  
Done
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.

Add support for sending acr_values
1 participant
@timnolte