Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes User Linking & Creation Issues #392

Merged
merged 1 commit into from
Mar 19, 2022

Conversation

timnolte
Copy link
Collaborator

@timnolte timnolte commented Mar 17, 2022

All Submissions:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

  1. Setup the OIDC Client settings with any combination of "Link Existing Users", "Create user if does not exist", "Identify with User Name".
  2. Login with a configured IDP with credentials based on the configured options.
  3. Observe the correct client authentication, linking, creation handling.
  4. Regardless of the casing of either the WordPress user or the IDP user accounts should properly link when specified.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

Fixes issues with improperly handling combinations of the "Link Existing Users", "Create user if does not exist", and "Identify with User Name" configuration options. Also addresses issues related to case sensitivity of usernames when attempting to "Link Existing Users".

@timnolte timnolte self-assigned this Mar 17, 2022
@timnolte timnolte added the status: needs review PR that needs review. label Mar 17, 2022
@timnolte timnolte added this to To do in 3.9.0 Release via automation Mar 17, 2022
@timnolte timnolte added this to the 3.9.0 milestone Mar 17, 2022
@zlmitchell
Copy link

This change worked for our environment. Thanks Tim.

@timnolte timnolte marked this pull request as ready for review March 18, 2022 12:16
* Fixes issues with improperly handling combinations of the
  "Link Existing Users", "Create user if does not exist", and
  "Identify with User Name" configuration options.
* Addresses issues related to case sensitivity of usernames
  when attempting to "Link Existing Users".
* Fixes typos and formatting on the plugin Settings screen.
@timnolte timnolte force-pushed the fix/case-sensitive-identity-mapping branch from 3729ca4 to 3f8629e Compare March 18, 2022 12:19
@timnolte timnolte merged commit 30eafa5 into oidc-wp:dev Mar 19, 2022
3.9.0 Release automation moved this from To do to Done Mar 19, 2022
@timnolte timnolte deleted the fix/case-sensitive-identity-mapping branch March 19, 2022 00:24
@timnolte timnolte added bug status: approved PRs that have been approved and ready to be merged. and removed status: needs review PR that needs review. labels Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment