-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Clean up PHPStan configuration #420
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@szepeviktor these changes cause the static analysis checks to fail due to including the Uses func_get_args()
check again after it was remove since it never shows up in the code. Also you have made significant changes without much details on why you removed them. My biggest concern was removing %rootDir%/../../php-stubs/wordpress-stubs/wordpress-stubs.php
from the bootstrapFiles
or is PHPStan able to autoload these?
Hello! The package I may have introduced failures. Fixing now ... |
I hope you like 47 lines of deletion :) |
Signed-off-by: Viktor Szépe <viktor@szepe.net>
All Submissions:
Changes proposed in this Pull Request:
Clean up PHPStan configuration.