Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Clean up PHPStan configuration #420

Merged
merged 8 commits into from
Jun 23, 2023
Merged

chore: Clean up PHPStan configuration #420

merged 8 commits into from
Jun 23, 2023

Conversation

szepeviktor
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Clean up PHPStan configuration.

@timnolte timnolte closed this Aug 19, 2022
@timnolte timnolte reopened this Aug 19, 2022
Copy link
Collaborator

@timnolte timnolte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szepeviktor these changes cause the static analysis checks to fail due to including the Uses func_get_args() check again after it was remove since it never shows up in the code. Also you have made significant changes without much details on why you removed them. My biggest concern was removing %rootDir%/../../php-stubs/wordpress-stubs/wordpress-stubs.php from the bootstrapFiles or is PHPStan able to autoload these?

@szepeviktor
Copy link
Contributor Author

My biggest concern was removing %rootDir%/../../php-stubs/wordpress-stubs/wordpress-stubs.php from the bootstrapFiles or is PHPStan able to autoload these?

Hello! The package szepeviktor/phpstan-wordpress loads WP core stubs.
https://github.com/szepeviktor/phpstan-wordpress/blob/c9fb3dc5e0a964845f6124a9c4394987749c657b/extension.neon#L93-L95

I may have introduced failures. Fixing now ...

@szepeviktor
Copy link
Contributor Author

I hope you like 47 lines of deletion :)

@timnolte timnolte self-assigned this Jun 23, 2023
@timnolte timnolte added the refactor Issues & PRs related to code refactoring. label Jun 23, 2023
@timnolte timnolte added this to In progress in 3.9.2 Release via automation Jun 23, 2023
@timnolte timnolte added this to the 3.9.2 milestone Jun 23, 2023
3.9.2 Release automation moved this from In progress to Reviewer approved Jun 23, 2023
@timnolte timnolte changed the title Clean up PHPStan configuration chore: Clean up PHPStan configuration Jun 23, 2023
@timnolte timnolte merged commit 32ea730 into oidc-wp:dev Jun 23, 2023
5 checks passed
3.9.2 Release automation moved this from Reviewer approved to Done Jun 23, 2023
@szepeviktor szepeviktor deleted the patch-1 branch June 23, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Issues & PRs related to code refactoring.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants