Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #458 Log Cleanup When Log Limit Changed #489

Merged
merged 2 commits into from
Jun 23, 2023

Conversation

timnolte
Copy link
Collaborator

All Submissions:

Changes proposed in this Pull Request:

  • Updates the minimum PHP version to 7.4.
  • Updates the development PHP version to 8.0.
  • Updates the development dependencies to the latest versions.
  • Updates additional linting & static analysis dependencies.
  • Fixes newly identified linting & static analysis errors.
  • Fixes Log Cleanup when Log Limit Changed #458.
  • Updates the log cleanup handling to properly retain the configured number of log entries.
  • Updates the log display output to reflect the log retention policy.

How to test the changes in this Pull Request:

  1. Login to the WordPress Dashboard.
  2. Turn on the plugin logging.
  3. Configure the desired log entries retention.
  4. Access the site login page to observe log entries being created.
  5. Observe that after hitting the desired retention length old record roll off with new one being added.
  6. Change the log retention number.
  7. Observe that the logs listed reflect the new log limit if it is smaller.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

  • Updates the log cleanup handling to properly retain the configured number of log entries.
  • Updates the log display output to reflect the log retention policy.

* Updates the minimum PHP version to 7.4.
* Updates the development PHP version to 8.0.
* Updates the development dependencies to the latest versions.
* Updates additional linting & static analysis dependencies.
* Fixes newly identified linting & static analysis errors.
* Fixes #458.
* Updates the log cleanup handling to properly retain the configured
  number of log entries.
* Updates the log display output to reflect the log retention policy.
@timnolte timnolte linked an issue Jun 23, 2023 that may be closed by this pull request
@timnolte timnolte self-assigned this Jun 23, 2023
@timnolte timnolte added the bug label Jun 23, 2023
@timnolte timnolte added this to In progress in 3.9.2 Release via automation Jun 23, 2023
@timnolte timnolte added this to the 3.9.2 milestone Jun 23, 2023
@timnolte timnolte merged commit 4d52d80 into dev Jun 23, 2023
8 checks passed
3.9.2 Release automation moved this from In progress to Done Jun 23, 2023
@timnolte timnolte deleted the fix/458-log-cleanup-when-log-limit-changed branch June 23, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Log Cleanup when Log Limit Changed
1 participant