[builtin/printf] Fix crash when no arguments are passed.

Addresses issue #404.
oils-for-unix · Jul 7, 2019 · a39bfe3 · a39bfe3
1 parent 9f0efb6
commit a39bfe3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/frontend/args.py b/frontend/args.py
@@ -125,12 +125,12 @@ def ReadRequired(self, error_msg):
     return arg
 
   def ReadRequired2(self, error_msg):
-    spid = self.spids[self.i]
     try:
       arg = self.Peek()
     except IndexError:
       # point at argv[0]
       raise UsageError(error_msg, span_id=self._FirstSpanId())
+    spid = self.spids[self.i]
     self.Next()
     return arg, spid
 

diff --git a/spec/builtin-printf.test.sh b/spec/builtin-printf.test.sh
@@ -14,6 +14,12 @@
 #
 # I suppose it is technically correct, but it looks very ugly.
 
+#### printf with no args
+printf
+## status: 2
+## OK dash/mksh/zsh status: 1
+## stdout-json: ""
+
 #### printf -v %s
 var=foo
 printf -v $var %s 'hello there'