Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make spec/stateful run against oil-native #1375

Closed
andychu opened this issue Oct 14, 2022 · 3 comments
Closed

Make spec/stateful run against oil-native #1375

andychu opened this issue Oct 14, 2022 · 3 comments
Labels
interactive-shell pending-release signal-handling translation

Comments

@andychu
Copy link
Contributor

andychu commented Oct 14, 2022

Right now it's failing at expect_prompt(sh)

Core issue: correct behavior of trap handlers is inherently tied to time -- when is the signal received, and when is it run on the main loop?
@andychu
Copy link
Contributor Author

andychu commented Oct 14, 2022

what does the main loop of a shell do?

  • running user code in a tree interpreter
  • waitpid(-1) -- blocking and interruptible
  • read() -- blocking and interruptible
  • it's in a C signal handler
  • running trap code
  • interactive shell: enters the main loop of GNU readline (SIGWINCH)

@andychu
Copy link
Contributor Author

andychu commented Apr 1, 2023 •
edited

I did this recently with Melvin's job control PR !

@andychu
Copy link
Contributor Author

andychu commented May 13, 2023

Released - https://www.oilshell.org/blog/2023/05/release-0.15.0.html

@andychu andychu closed this as completed May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
interactive-shell pending-release signal-handling translation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andychu