Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ソフトウェアバージョンアップ対応(FrontEnd) #530

Closed
itutu-tienday opened this issue Jul 3, 2023 · 4 comments
Closed
Labels
enhancement New feature or request frontend For frontend app tasks

Comments

@itutu-tienday
Copy link
Collaborator

itutu-tienday commented Jul 3, 2023

optinistのソフトウェア・ミドルウェアのバージョンアップの実施

@reactplus-thom
Copy link
Collaborator

  • Thực hiện version-up đối với software/middleware của optinist

  • Nội dung thực hiện:

(Ticket này chỉ đối ứng cho phía FE)

  • Version up Node.js
  • Version up middleware
  • Lọa bỏ cảnh báo khi build(--openssl-legacy-provider, etc)
  • Các bước thực hiện
  1. Điều tra phạm vi cần đối ứng và báo cáo
  2. Sau khi phía khách hàng review xong kết quả điều tra thì mới bắt đầu tiến hành
  3. Tiến hành và sau đó là test (xác nhận hoạt động)

@reactplus-thom
Copy link
Collaborator

reactplus-thom commented Jul 3, 2023

@itutu-tienday
調査結果は以下のとおりに報告いたします。
ご確認のほどお願いいたします。


基本的には、MRI (https://github.com/arayabrain/MRIAnalysisStudioforMouse/tree/feature/node-18)の対応内容と同様な対応になると思います。

対応範囲としては以下のような想定です。
・Node 17以降ではSSLがバージョンアップされている状態のため、導入しているパッケージに影響がでます。
→@types/react, types/react-dom, react, react-domに対してもNode 18にバージョンアップする必要があります。
・stream, assertのパッケージを追加する必要です。
・react-scriptsはバージョン5にアップグレードする必要あります。
・React18ではdefault typeからchildenが外されるため、Funtionコンポネントのtypeにchildenを追加する必要です。

@reactplus-thom
Copy link
Collaborator

Version up lên Node.js 20

@ReiHashimoto
Copy link
Collaborator

resolved in ver1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend For frontend app tasks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants