requires allegro 5.0.9

[stsp]

The code seems to be using many functions from
allegro-5.1, that are not available in 5.0. But only
version 5.0 is checked in configure. As a result,
the following link errors:

anim.c:(.text+0x916): undefined reference to al_set_display_flag' anim.c:(.text+0xad4): undefined reference toal_set_display_flag'
src/kernel/video.o: In function init_video': video.c:(.text+0x365): undefined reference toal_create_builtin_font'
src/kernel/audio.o: In function enable_audio': audio.c:(.text+0x142): undefined reference toal_set_mixer_gain'
audio.c:(.text+0x1a6): undefined reference to al_set_mixer_gain' src/kernel/audio.o: In functionset_mixer_gain':
audio.c:(.text+0x200): undefined reference to al_set_mixer_gain' src/kernel/dialog.o: In functioninit_dialog':
dialog.c:(.text+0x7): undefined reference to al_init_native_dialog_addon' src/kernel/dialog.o: In functionfinalize_dialog':
dialog.c:(.text+0x43): undefined reference to `al_shutdown_native_dialog_addon'

It would be nice if allegro-5.0 is properly supported, rather
than to tighten the version check. fedora-23 only has 5.0.

[jolfzverb]

Hello stsp!
I am not sure that mininim requires version 5.1, I'm building it with media-libs/allegro-5.0.11.

[stsp]

Unfortunately I can't find the 5.0.11 tag here:
https://github.com/liballeg/allegro5/tree/5.0
I think ubuntu have packaged it on their own.
Fedora has allegro5-5.0.3 which is not enough
to build the game.

[f2404]

5.0.11 is available here: http://liballeg.org/

2015-01-11 - Allegro 5.0.11 released!

[stsp]

OKey, so they should learn about tagging the
releases. :)
Anyway, then the configure check should be
tightened to require >=5.0.11 (or whatever the
minimal version is sufficient).

[stsp]

OK, I see a more complete list of tags here:
https://github.com/liballeg/allegro5/tags

[oitofelix]

I use Allegro 5.0.10 for MININIM development, bundled with Debian Jessie. I didn't know if that version was strictly required, though. I still don't know what's the minimum required version.

[stsp]

OK, the mixer gain functions were added in 5.0.6.

[oitofelix]

Please, could you try to build the HEAD against Allegro 5.0.6, so we find out what's the minimum required version?

[stsp]

I did the tests, and the minimum version is 5.0.9.
Namely this commit is important:

commit eb5f84aa0ce4f5371e9ca14a0b9587d967dae630
Author: Peter Wang tjaden@users.sourceforge.net
Date: Sun Feb 17 10:38:37 2013 +1100

docs: Mark 5.0.9 additions.

al_set_display_icons
al_init_native_dialog_addon
al_shutdown_native_dialog_addon

(cherry picked from commit c0f013602e920501eaa4aa2b13d5904281861626)

[stsp]

I still wonder what this error means (unrelated to allegro):

GEN mininim.1
make[4]: вход в каталог «/home/stas/src/mininim»
make[4]: «mininim» не требует обновления.
make[4]: выход из каталога «/home/stas/src/mininim»
help2man: can't get --help' info from ../../mininim Try--no-discard-stderr' if option outputs to stderr
Makefile:1161: ошибка выполнения рецепта для цели «mininim.1»

[oitofelix]

stsp commented:
I did the tests, and the minimum version is 5.0.9.

Thank you! I'll commit the change for the configure script to check for this minimum version.

stsp commented:
I still wonder what this error means (unrelated to allegro):

Could you, please, open another issue for this error. Please, include config.log, and other relevant information like make command-line invocation, build directory layout (VPATH build?), operating system and so on...

[oitofelix]

Solved in commit a763650.

[stsp]

Could you, please, open another issue for this error.

OK, I've found the reason.
help2man was running "mimimim --help", but at that point
I didn't yet run ldconfig after installing allegro. As such, this
returned an error.
IMHO it is a bit nasty that while you build something, it
should be already runnable. OTOH perhaps allegro had
to run ldconfig by "make install" itself.
So while there is a bug here somewhere, perhaps it should
be opened not here.

[oitofelix]

Agreed, it's not a MININIM bug. Yet not ideal help2man usage at build time is a common practice.

[stsp]

Actually I think perhaps you can add a
separate target for this, like "make docs"
or whatever. It may be a non-default target,
but a dependency for "install" target.
This will kind of fix the problem, and I think
this is quite a common practice too, but of
course this is just a wish-list item.

[stsp]

https://bugzilla.redhat.com/show_bug.cgi?id=1312588

[oitofelix]

Nicely done. Thank you.