Replace ecdsa with PyCA/cryptography #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks really nice. Is this ready for review? |
Dependency on ecdsa is a problem for all applications and users that have strict crypto requirements and do not permit custom implementations of cryptographic algorithms. The package even warns that it is potentially insecure and does not protect against side channel attacks. It's less of an issue for pubkeys, but still a compliance issue. Cryptography can handle ecdsa SSH keys without help of ecdsa Python package. The PR replaces the key verification code. I have also included a (mostly untested) re-implementation of ecdsa.key.VerifyingKey. Signed-off-by: Christian Heimes <christian@python.org>
|
@sometato Yes, could you please approve CI run? |
ojarva
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency on ecdsa is a problem for all applications and users that
have strict crypto requirements and do not permit custom implementations
of cryptographic algorithms. The package even warns that it is
potentially insecure and does not protect against side channel attacks.
It's less of an issue for pubkeys, but still a compliance issue.
Cryptography can handle ecdsa SSH keys without help of ecdsa Python
package. The PR replaces the key verification code. I have also included
a (mostly untested) re-implementation of ecdsa.key.VerifyingKey.
Signed-off-by: Christian Heimes christian@python.org