Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename file to conform to psr-4 autoloading standard #28

Merged
merged 1 commit into from
May 10, 2020

Conversation

knox2
Copy link
Contributor

@knox2 knox2 commented May 9, 2020

This pull request renames the RunTimeException.php file to RuntimeException.php to conform to the psr-4 php standard.

Currently composer gives the below deprecated notice:

Deprecation Notice: Class CurrencyConverter\Exception\RuntimeException located in ./vendor/ujjwal/currency-converter/src/Exception/RunTimeException.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///usr/local/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:201

This fixes the above issue

@ojhaujjwal
Copy link
Owner

Thanks for the PR @knox2. Do you mind removing the existing RunTimeException.php too?

@ojhaujjwal ojhaujjwal merged commit cf62b2c into ojhaujjwal:master May 10, 2020
@ojhaujjwal
Copy link
Owner

I removed the file myself as it was a minor change.
I also published https://github.com/ojhaujjwal/currency-converter-php/releases/tag/2.5.1.
Thanks for your contribution. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants